-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FU oracle operator CLI #10570
FU oracle operator CLI #10570
Conversation
Deploying agoric-sdk with Cloudflare Pages
|
308d9e1
to
de2b539
Compare
de2b539
to
f275684
Compare
Thanks for the heads up. Will pick up #10514 tomorrow. Once that's done, it'll be easy to clear out agoric-cli pieces from |
f275684
to
14ac9a7
Compare
6238cd8
to
18a8219
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PS: currently test-docker-build
job is failing, I'm hoping this is a flake and when mergify re-run all CI tasks this job will pass
refs: #10567
Description
This sets up a CLI for transaction oracle operators. It has tests but I don't expect them to pass yet.
I think this is worth landing to get the CLI scaffolded and the refactorings of agoric-cli to client-utils that support it. In particular moving the
AGORIC_NET
convention down toclient-utils
in a cli.js module and other network config helpers in network-config.js.It will also help to DRY out the 'test-lib' code in a3p proposals that was copied from agoric-cli (e.g.
rpc.js
) cc @anilhelvaciSecurity Considerations
agoric-cli will source its network config lookup function from another package. That's a potential supply chain weakness but it's the same org as the agoric-cli and it's very unlikely only one would be compromised if either were.
Scaling Considerations
none
Documentation Considerations
Includes CLI help and a demonstration test
Testing Considerations
I added a test that runs in CI but doesn't cause a failure so that this can live in master while we build it out
Upgrade Considerations
none