Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FU oracle operator CLI #10570

Merged
merged 8 commits into from
Nov 27, 2024
Merged

FU oracle operator CLI #10570

merged 8 commits into from
Nov 27, 2024

Conversation

turadg
Copy link
Member

@turadg turadg commented Nov 26, 2024

refs: #10567

Description

This sets up a CLI for transaction oracle operators. It has tests but I don't expect them to pass yet.

I think this is worth landing to get the CLI scaffolded and the refactorings of agoric-cli to client-utils that support it. In particular moving the AGORIC_NET convention down to client-utils in a cli.js module and other network config helpers in network-config.js.

It will also help to DRY out the 'test-lib' code in a3p proposals that was copied from agoric-cli (e.g. rpc.js) cc @anilhelvaci

Security Considerations

agoric-cli will source its network config lookup function from another package. That's a potential supply chain weakness but it's the same org as the agoric-cli and it's very unlikely only one would be compromised if either were.

Scaling Considerations

none

Documentation Considerations

Includes CLI help and a demonstration test

Testing Considerations

I added a test that runs in CI but doesn't cause a failure so that this can live in master while we build it out

Upgrade Considerations

none

Copy link

cloudflare-workers-and-pages bot commented Nov 26, 2024

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: 18a8219
Status: ✅  Deploy successful!
Preview URL: https://070fe95b.agoric-sdk.pages.dev
Branch Preview URL: https://10567-operator-cli.agoric-sdk.pages.dev

View logs

@turadg turadg force-pushed the 10567-operator-cli branch 2 times, most recently from 308d9e1 to de2b539 Compare November 26, 2024 16:42
@turadg turadg marked this pull request as ready for review November 26, 2024 16:42
@turadg turadg requested a review from a team as a code owner November 26, 2024 16:42
@turadg turadg added the force:integration Force integration tests to run on PR label Nov 26, 2024
@anilhelvaci
Copy link
Collaborator

It will also help to DRY out the 'test-lib' code in a3p proposals that was copied from agoric-cli (e.g. rpc.js)

Thanks for the heads up. Will pick up #10514 tomorrow. Once that's done, it'll be easy to clear out agoric-cli pieces from test-lib

@turadg turadg added the automerge:rebase Automatically rebase updates, then merge label Nov 26, 2024
Copy link
Contributor

@LuqiPan LuqiPan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

PS: currently test-docker-build job is failing, I'm hoping this is a flake and when mergify re-run all CI tasks this job will pass

@mergify mergify bot merged commit a2e9363 into master Nov 27, 2024
81 checks passed
@mergify mergify bot deleted the 10567-operator-cli branch November 27, 2024 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:rebase Automatically rebase updates, then merge force:integration Force integration tests to run on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants