feat(scripts): Rewrite gen-upgrade-proposal.sh #10590
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #8784 * script arguments for target release/tag/commit and Cosmos upgrade name, plus pass-through of arbitrary `agd tx` arguments * automatic selection of upgrade name from gen-github-release.sh release contents, with interactive disambiguation (where possible) of multiple candidates * reasonable defaults for title and description from gen-github-release.sh release contents * script option `--send` to invoke `agd tx` rather than just printing it out (but successfully invocation additionally requires `--from` etc.) * readable output of the `agd tx` command and data affecting it, whether or not it is to be invoked directly * argument checking with readable error messages and usage details * use of GitHub requests and https://main.agoric.net/network-config, overridable by environment variables
Deploying agoric-sdk with
|
| Latest commit: |
fdf65b8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://54be4070.agoric-sdk.pages.dev |
| Branch Preview URL: | https://gibson-8784-scriptable-gen-u.agoric-sdk.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8784
Description
agd txarguments--sendto invokeagd txrather than just printing it out (but successfully invocation additionally requires--frometc.)agd txcommand and data affecting it, whether or not it is to be invoked directlySample use:
Security Considerations
This script is not directly on a security-critical path, but it is important for it to remain transparent for operators.
Scaling Considerations
n/a
Documentation Considerations
Includes embedded usage information, and also remains backwards-compatible in a zero-argument form that uses git HEAD as the target ref (although we should consider instead making target ref a required argument).
I'd also like to incorporate https://github.com/Agoric/estimator into
agditself, for something better than--upgrade-height "$(agoric-estimator -date '<DATE>' -rpc https://main.rpc.agoric.net:443 | tee /dev/stderr | sed -n '$s/.* //p')", but haven't done so in this PR.Testing Considerations
Tested manually, although I'm open to ideas.
Upgrade Considerations
None in particular.