Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(provisionPool): allow overriding PerAccountInitialAmount during contract upgrade #10594

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Jorge-Lopes
Copy link
Collaborator

@Jorge-Lopes Jorge-Lopes commented Dec 2, 2024

closes: #10562

Description

Note: this PR is currently defined as "DRAFT" because it should land after #10419

This PR updates the provisionPool contract to allow overriding the PerAccountInitialAmount parameter, which is governed by the Economic Committee during contract upgrades.

To achieve the above functionality, this PR introduces the following changes:

  • The PerAccountInitialAmount is now injected to the contract through privateArgs instead of terms.
  • Use the makeParamManagerFromTerms method from the governance package to manage the PerAccountInitialAmount values during upgrades.
  • Updated the public and creator facets to handle the replace handleParamGovernance with makeParamManagerFromTerms.

The core-eval proposal used to upgrade provisionPool was also updated to fetch the current value of PerAccountInitialAmount set on Vstorage and include it on the new privateArgs

Security Considerations

Scaling Considerations

Documentation Considerations

Testing Considerations

I have confirmed that the existing unit tests built for provisionPool continue to pass.

Along with the existing tests, these changes were also tested against the governance acceptance test, at a3p-integration, where one of the test cases is to ensure that the governed parameter values are intact after a contract upgrade.
That test is not included here to limit the scope of this PR.

Upgrade Considerations

Copy link

cloudflare-workers-and-pages bot commented Dec 2, 2024

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: d818720
Status:🚫  Build failed.

View logs

@Jorge-Lopes Jorge-Lopes added the force:integration Force integration tests to run on PR label Dec 2, 2024
@Jorge-Lopes Jorge-Lopes changed the title Provide ability to override the ProvisionPool governedParam PerAccountInitialAmount feat(provisionPool): allow overriding PerAccountInitialAmount during contract upgrade Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
force:integration Force integration tests to run on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to override the ProvisionPool governedParam PerAccountInitialAmount
1 participant