Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zoe contract typings #1488

Merged
merged 4 commits into from
Aug 16, 2020
Merged

Zoe contract typings #1488

merged 4 commits into from
Aug 16, 2020

Conversation

michaelfig
Copy link
Member

@michaelfig michaelfig commented Aug 16, 2020 •
edited
Loading

Some clearer types for sample Zoe contracts.

#dapp-encouragement-branch: new-zoe

@michaelfig michaelfig added the Zoe package: Zoe label Aug 16, 2020
@michaelfig michaelfig self-assigned this Aug 16, 2020
@michaelfig michaelfig mentioned this pull request Aug 16, 2020
Merged
erights
erights approved these changes Aug 16, 2020
View reviewed changes
Copy link
Member

@erights erights left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/zoe/src/contracts/mintAndSellNFT.js Outdated Show resolved Hide resolved
@michaelfig michaelfig merged commit d72fd55 into zoe-release-candidate Aug 16, 2020
@michaelfig michaelfig deleted the mfig/zoe-contract-typings branch August 16, 2020 17:31
@turadg turadg mentioned this pull request Apr 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erights erights erights approved these changes

@dtribble dtribble Awaiting requested review from dtribble

Assignees

@michaelfig michaelfig

Labels
Zoe package: Zoe
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelfig @erights