Stargate upgrade #1634
Merged
Stargate upgrade #1634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelfig
force-pushed
the
mfig/1621-stargate-upgrade
branch
6 times, most recently
from
66035a4 to
6c7603e
Compare
michaelfig
force-pushed
the
mfig/1621-stargate-upgrade
branch
from
6c7603e to
1c649a1
Compare
kriskowal
reviewed
Sep 3, 2020
|
Our Stargate adoption is really close. Just waiting on the IBC relayer Stargate compatibility (IBC async acknowledgements can land later). The big dipper block explorer is just waiting on some cosmos-sdk fixes to view transactions. |
michaelfig
force-pushed
the
mfig/1621-stargate-upgrade
branch
5 times, most recently
from
cd3d204 to
ca8eba9
Compare
michaelfig
force-pushed
the
mfig/1621-stargate-upgrade
branch
from
ca8eba9 to
78007c5
Compare
michaelfig
force-pushed
the
mfig/1621-stargate-upgrade
branch
from
78007c5 to
38e170d
Compare
kriskowal
approved these changes
Oct 8, 2020
| if (!exitStatus && !capret[1].includes('code: 0')) { | ||
| exitStatus = 2; | ||
| if (!exitStatus) { | ||
| const ret = JSON.parse(capret[1]); |
There was a problem hiding this comment.
This can throw and the error messages are opaque. Consider using a utility method that rethrows an informative error.
There was a problem hiding this comment.
Okay, I'll do that in the next batch of changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1621
Changes needed for the new Cosmos Stargate release version of cosmos-sdk/gaia.
Before this PR can be reviewed, we need the following:
canEncodeTypecheck fails for repeated values cosmos/cosmos-sdk#7222After review, we are waiting on the following external dependencies before we can land this in a release: