Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get dynamic IBC working again #2426

Merged
merged 5 commits into from
Feb 15, 2021
Merged

Get dynamic IBC working again #2426

merged 5 commits into from
Feb 15, 2021

Conversation

michaelfig
Copy link
Member

Closes #2067

Works with cosmos/relayer#428

We need this to release agorictest-5.

@michaelfig michaelfig added the cosmic-swingset package: cosmic-swingset label Feb 15, 2021
@michaelfig michaelfig requested a review from dckc February 15, 2021 17:19
@michaelfig michaelfig self-assigned this Feb 15, 2021
Copy link
Member

@dckc dckc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see...

I'm happy to say that after cosmos/relayer#428 , Agoric's dIBC works again (cosmos-sdk v0.41.0)!

How can I reproduce the sense in which this "works"?

i.e. how can I verify that #2067 is fixed?

packages/cosmic-swingset/bin/ag-nchainz Show resolved Hide resolved
packages/cosmic-swingset/bin/ag-nchainz Show resolved Hide resolved
golang/cosmos/app/app.go Show resolved Hide resolved
@michaelfig
Copy link
Member Author

How can I reproduce the sense in which this "works"?

I'll add a document with my usage notes explaining how to test.

@michaelfig
Copy link
Member Author

How can I reproduce the sense in which this "works"?

I'll add a document with my usage notes explaining how to test.

@dckc, this should be R4R. See README-dibc.md in this PR for testing instructions.

@dckc
Copy link
Member

dckc commented Feb 15, 2021

It seems to work but for the last step:

ag-ibc/packages/cosmic-swingset/relayer$ rly tx xfer ibc1 ibc0 10000n0token true $(rly keys show ibc0 testkey) -ppath-2
Error: accepts 4 arg(s), received 5

what clue am I missing?

@dckc
Copy link
Member

dckc commented Feb 15, 2021

might be worth noting that building the relayer currently requires git with --show-current support, which only appeared in git 2.22.0 .

That is: while building the relayer , I got:

error: unknown option `--show-current'

Evidently --show-current requires git 2.22.0, but Ubuntu 18.04 only supplies 2.17.1.

I used nix-shell -p git to get 2.29.2.

@michaelfig michaelfig merged commit 034b649 into master Feb 15, 2021
@michaelfig michaelfig deleted the mfig-2067-dibc-working branch February 15, 2021 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cosmic-swingset package: cosmic-swingset
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get IBC working on our current agoric-sdk
2 participants