Add ability to request stats for a Vat. #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Chris-Hibbert
force-pushed
the
createDynamicVats
branch
2 times, most recently
from
32b77a5 to
f7c09eb
Compare
Chris-Hibbert
force-pushed
the
vatStats
branch
from
d868b10 to
cce79bf
Compare
Chris-Hibbert
force-pushed
the
vatStats
branch
2 times, most recently
from
b159f74 to
ea444f3
Compare
warner
approved these changes
Jan 15, 2020
| @@ -507,6 +507,15 @@ export default function makeKernelKeeper(storage) { | |||
| }); | |||
| } | |||
|
|
|||
| function vatStats(vatID) { | |||
| return harden({ | |||
| nextObjectId: storage.get(`${vatID}.o.nextID`), | |||
There was a problem hiding this comment.
do these want to be Nat(Number(xx)) instead of strings?
Chris-Hibbert
force-pushed
the
createDynamicVats
branch
2 times, most recently
from
ac545fc to
77820e3
Compare
Changes from a previous version: * Subtract the starting index to give counts * ask the vat manager rather than the kernelKeeper. remaining question: is the serialized object containing stats safe, or should it be turned into text?
Chris-Hibbert
force-pushed
the
vatStats
branch
from
ea444f3 to
42291ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds collectVatStats and registers it with the device. Returns some basic stats about a vat.
The base change for the vatAdmin changes is here. See this discussion for context.