Begin codifying the use of NPM dist-tags #4117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelfig
added
agoric-cli
dckc
approved these changes
Nov 24, 2021
| /******/ ]); |
There was a problem hiding this comment.
TIL: we keep copies of yarn releases in our tree
packages/ERTP/CHANGELOG.md
Outdated
|
|
||
| * **ERTP:** NatValues now only accept bigints, lower-case amountMath is removed, and AmountMath methods always follow the order of: brand, value | ||
|
|
||
| * chore: fix up INPUT_VALIDATON.md |
packages/SwingSet/CHANGELOG.md
Outdated
|
|
||
| ### ⚠ BREAKING CHANGES | ||
|
|
||
| * remove newSwap; replace with constantProduct AMM where needed (#4097) |
There was a problem hiding this comment.
In the swingset package, removing newswap doesn't seem like a breaking change. I bet it's just some test reorg that ideally would have been a separate commit. I suppose I reviewed this one but didn't consider how squashing would impact release notes
| @@ -57,5 +57,8 @@ | |||
| "test/**/test-*.js" | |||
| ], | |||
| "timeout": "2m" | |||
| }, | |||
| "publishConfig": { | |||
| "access": "public" | |||
There was a problem hiding this comment.
Commit message seems like it could be more specific
michaelfig
force-pushed
the
mfig-npm-dev
branch
8 times, most recently
from
c2aea65
to
3838b3e
Compare
dckc
reviewed
Nov 24, 2021
Also, pivot to `latest` NPM dist-tag.
michaelfig
force-pushed
the
mfig-npm-dev
branch
3 times, most recently
from
e6dfb2a
to
9ba832e
Compare
dckc
reviewed
Nov 24, 2021
| # Adapted from https://johnny.sh/notes/publish-canary-lerna-cicd/ | ||
| - name: configure NPM token | ||
| run: | | ||
| echo "//registry.npmjs.org/:_authToken=${NPM_TOKEN}" > ~/.npmrc |
|
looks like this refs: #3857 |
michaelfig
force-pushed
the
mfig-npm-dev
branch
2 times, most recently
from
4532ba9
to
6ee4e6e
Compare
dckc
approved these changes
Nov 24, 2021
michaelfig
added
the
automerge:no-update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #3857
Description
Begin distinguishing between
latest,dev(and hopefully soonbeta) tags that users canagoric install latestin order to keep their dapp dependencies up-to-date.This will make dapp dependency management more like typical Yarn. We also add a CI
dev-canarypublish on push to master, so thatagoric install devwill get the freshest code.Drive-by: try incorporating the Node 16
CXXFLAGSsupport discovered by @robert-zaremba.Security Considerations
Documentation Considerations
Testing Considerations