feat(notifier): subscription kit history limit #5403
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@michaelfig be aware that @dtribble also has a sketch of a prefix lossy subscriber at https://gist.github.com/dtribble/4e7cc65fb0fa8aab5a4069e80d915454 , that we've been meaning to talk about. I think it is very close. Your approach seems very different. We should understand these differences before proceeding with an approach. |
|
Withdrawing in favour of the new-and-improved subscriptions/notifiers @erights is working on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #5346
Description
Implements "prefix lossy subscriptions" via
makeSubscriptionKit(historyLimit)parameter (default=Infinity).Security Considerations
Improves memory profile, given cooperating subscribers (an old and slow subscription may still hold references to the entire history, but new ones won't).
Documentation Considerations
Documented in README.md and backwards compatible.
Testing Considerations
The test suite tests several important values of historyLimit.