Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chain storage revamp #5465

Merged
merged 8 commits into from
Jun 5, 2022
Merged

Chain storage revamp #5465

merged 8 commits into from
Jun 5, 2022

Conversation

michaelfig
Copy link
Member

@michaelfig michaelfig commented May 29, 2022 •
edited
Loading

closes: #5406

Description

Mass exodus of storage system from x/swingset to x/vstorage. This replaces #5406, and incorporates all of its semantic changes.

x/vstream (#5466) is a layer on top of x/vstorage with change notification events to enable future subscriptions as well as historical backfilling.

Security Considerations

Documentation Considerations

Testing Considerations

@michaelfig michaelfig requested a review from JimLarson May 29, 2022 04:30
@michaelfig michaelfig mentioned this pull request May 29, 2022
Closed
@michaelfig michaelfig changed the title Mfig chain storage revamp Chain storage revamp May 29, 2022
@michaelfig michaelfig force-pushed the mfig-chain-storage-revamp branch 3 times, most recently from 9bbda6f to a586454 Compare May 29, 2022 20:36
@michaelfig michaelfig self-assigned this May 29, 2022
@michaelfig michaelfig force-pushed the mfig-chain-storage-revamp branch 2 times, most recently from 150f7e6 to 4d0a72f Compare May 29, 2022 22:29
@michaelfig
Copy link
Member Author

Note to reviewers; the only CI failure is for protobuf backward incompatibility. I think that's okay, since this is advertised as a breaking change.

JimLarson
JimLarson approved these changes Jun 4, 2022
View reviewed changes
Copy link
Contributor

@JimLarson JimLarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Review items are mostly about comments, naming, and refactoring and I trust you to apply them judiciously, but I'd also be happy to take another look before merging.

golang/cosmos/app/app.go Outdated Show resolved Hide resolved
golang/cosmos/proto/agoric/swingset/swingset.proto Show resolved Hide resolved
golang/cosmos/proto/agoric/vstorage/genesis.proto Outdated Show resolved Hide resolved
golang/cosmos/proto/agoric/vstorage/genesis.proto Show resolved Hide resolved
golang/cosmos/proto/agoric/vstorage/query.proto Show resolved Hide resolved
golang/cosmos/x/vstorage/keeper/keeper.go Outdated Show resolved Hide resolved
golang/cosmos/x/vstorage/keeper/keeper.go Outdated Show resolved Hide resolved
golang/cosmos/x/vstorage/keeper/querier.go Outdated Show resolved Hide resolved
golang/cosmos/x/vstorage/keeper/querier.go Outdated Show resolved Hide resolved
golang/cosmos/x/vstorage/types/path_keys.go Outdated Show resolved Hide resolved
@michaelfig michaelfig added the automerge:no-update (expert!) Automatically merge without updates label Jun 5, 2022
@mergify mergify bot merged commit 2f9eb8b into master Jun 5, 2022
@mergify mergify bot deleted the mfig-chain-storage-revamp branch June 5, 2022 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JimLarson JimLarson JimLarson approved these changes

Assignees

@michaelfig michaelfig

Labels
agoric-cosmos automerge:no-update (expert!) Automatically merge without updates proto:expect-breakage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelfig @JimLarson