feat: add config flag to control fakeDurable
#5526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warner
approved these changes
Jun 7, 2022
packages/SwingSet/test/enable-fake-durable/test-enable-fake-durable.js
Outdated
Show resolved
Hide resolved
| @@ -1005,6 +1005,7 @@ test('dropImports', async t => { | |||
| () => { | |||
| return { buildRootObject: build }; | |||
| }, | |||
| false, | |||
There was a problem hiding this comment.
part of me wants to suggest that the makeLiveSlots() argument should declare a default allowFakeDurable = false, and then this line goes away, but part of me thinks explicit is better
There was a problem hiding this comment.
Suspenders AND belt: I'll default the argument in makeLiveSlots but pass it explicitly here anyway.
FUDCo
force-pushed
the
5489-control-fake-durable
branch
from
3487d6f
to
4ac9764
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swingset now forbids the use of the
fakeDurablefeature unless a global config flagenableFakeDurableis set to true in the kernel's config options.fakeDurableis enabled without configuration in the mock virtual stuff.Closes #5489