Implement smart-wallet and read-only UI #5594
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add smartWallet bundle, installation to @agoric/vats - add .smartWallet property in makeClientBanks - initial smart-wallet.js contract
demo: $ agd query vstorage keys published.wallet children: - agoric1n9ea2m4987r93q4df8cckyg6n3sw685jx0jf8h $ agoric follow :published.wallet.agoric1n9ea2m4987r93q4df8cckyg6n3sw685jx0jf8h ...
dckc
requested changes
Jun 16, 2022
Comment on lines
+252
to
+256
| const myAddressNameAdmin = E(namesByAddressAdmin).lookupAdmin(address); | ||
| const myWallet = E(zoe).startInstance( | ||
| smartWallet, | ||
| {}, | ||
| { agoricNames, bank, namesByAddress, myAddressNameAdmin, board }, |
There was a problem hiding this comment.
Both the smartWallet contract an ag-solo use myAddressNameAdmin to set up depositFacet. There can be only one. This is why we see 0 invitations in xnet #5513 (comment) .
turadg
requested changes
Jun 29, 2022
| * marshaller?: ERef<Marshaller>, | ||
| * }} privateArgs | ||
| */ | ||
| export const start = async (zcf, privateArgs) => { |
There was a problem hiding this comment.
we need some test of this contract starting and the shape of its creatorFacet. I can help with that if you like.
| @@ -582,6 +581,7 @@ export function makeWallet({ | |||
|
|
|||
| const getAttBrand = makeMemoizedGetter(() => E(getAttIssuer()).getBrand()); | |||
|
|
|||
| /** @typedef {any} AttestationTool */ /* @@@ TODO */ | |||
|
overtaken by #5701 etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #5356
Description
Here's a (rather unimpressive) working demonstration of the smart wallet UI. Notice the zero-latency initialization of the view, and that it's currently read-only.
Screen.Recording.2022-06-14.at.3.11.50.PM.mov
Security Considerations
Documentation Considerations
Testing Considerations