feat(inter-protocol): add amm liquidity script #5938
Conversation
| // /** @type {<K extends string,V>(es: [K,V][]) => Record<K,V>} */ | ||
| // const recordFromEntries = Object.fromEntries; |
| // /** @type {<K extends string,V>(es: [K,V][]) => Record<K,V>} */ | ||
| // const recordFromEntries = Object.fromEntries; | ||
|
|
||
| const getOfferResult = async (instance, wallet, walletAdmin) => { |
| let result; | ||
| console.log('awaiting offers...'); | ||
| for await (const offers of makeNotifierFromAsyncIterable(offerIt)) { | ||
| console.log('offers iterator:', offers); |
There was a problem hiding this comment.
this is a next of the iterator, not the iterator itself
| status === 'complete' && invitationQuery.instance === instance, | ||
| ) | ||
| .forEach(async ({ id }) => { | ||
| result = await E(wallet).lookup('offerResult', id); |
There was a problem hiding this comment.
should this really run for each offer? seems like you want to .find the first match. In which case you don't need a separate filter.
result = offers.find(… )
if (result) break;|
|
||
| /** | ||
| * | ||
| * @param { any } homeP |
There was a problem hiding this comment.
not blocking, but do we have a type for this somewhere?
There was a problem hiding this comment.
It used to be import('./user-bundle').HomeBundle which was unresolved, not sure where it came from. And I couldn't find anything else in agoric-sdk that defines a proper type for homeP
| // const iNot = E(wb).getIssuersNotifier(); | ||
| // const { value: iEntries } = await E(iNot).getUpdateSince(); | ||
| // const issuers = recordFromEntries(iEntries); | ||
| // console.log(issuers); |
There was a problem hiding this comment.
dead code. if it's meant to be used for additional diagnostics, put it behind a flag to enable such diagnostics
| const offerConfig = { | ||
| id: `${now()}`, | ||
| invitation, | ||
| // installationHandle: amm.installation, |
Thanks, yea I'd rather just move forward with the next PR, it takes significant time to start a local chain and test this script from scratch. |
|
@arirubinstein note this perhaps obsoletes https://github.com/Agoric/inter-protocol-bootstrap/blob/main/add-initial-liquidity.js |
* feat(inter-protocol): add amm liquidity script * fix: remove dead code Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
refs: #5354