Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(swingset): don't un-expose 'gc', to stop intermittent test failures #6029

Merged
merged 1 commit into from
Aug 23, 2022
Merged

fix(swingset): don't un-expose 'gc', to stop intermittent test failures #6029

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions packages/SwingSet/src/lib-nodejs/engine-gc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,13 @@ if (typeof bestGC !== 'function') {
// Node.js v8 wizardry.
v8.setFlagsFromString('--expose_gc');
bestGC = vm.runInNewContext('gc');
// Hide the gc global from new contexts/workers.
v8.setFlagsFromString('--no-expose_gc');
// We leave --expose_gc turned on, otherwise AVA's shared workers
// may race and disable it before we manage to extract the
// binding. This won't cause 'gc' to be visible to new Compartments
// because SES strips out everything it doesn't recognize.

// // Hide the gc global from new contexts/workers.
// v8.setFlagsFromString('--no-expose_gc');
}

// Export a const.
Expand Down