feat(vats): upgrade to psm-first smart-wallet #6163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dckc
requested review from
turadg,
arirubinstein,
erights,
michaelfig,
Tartuffo and
dtribble
|
This is going to break the UI so I'll defer to @michaelfig or @samsiegart to approve. (I figured this swap would happen in #6134) I also have some concerns about swapping out the old wallet without removing it as 494c540 does. |
|
Fine with me if the swap happens in #6134; I just figured I would hoist this to prompt a few folks to perhaps give some input. |
samsiegart
approved these changes
Sep 9, 2022
dckc
force-pushed
the
dc-smartwallet-config
branch
from
4543355 to
3762fff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change the
walletFactorybundle to be built from packages/smart-wallet; that is: use the new contract in bootstrap.Security Considerations
smaller surface area for the contract
hardened with method schemas / patterns
Testing Considerations
existing unit tests are quite good. This PR proposes that the next phase of testing be shared by the team.