Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

6211 cli provision #6216

Merged
merged 3 commits into from
Sep 15, 2022
Merged

6211 cli provision #6216

merged 3 commits into from
Sep 15, 2022

Conversation

turadg
Copy link
Member

@turadg turadg commented Sep 15, 2022

Description

CLI for #6211

Adds an agoric wallet provision command

Security Considerations

--

Documentation Considerations

--

Testing Considerations

Updated smoke tests to use it

@dckc
Copy link
Member

dckc commented Sep 15, 2022 •
edited
Loading

default to dry run and warn about the 10BLD?

to get the actual price:

agd query swingset params
...
power_flag_fees:
- fee:
  - amount: "10000000"
    denom: ubld
  power_flag: SMART_WALLET

dckc
dckc approved these changes Sep 15, 2022
View reviewed changes
Copy link
Member

@dckc dckc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good stuff.

packages/agoric-cli/src/lib/chain.js Outdated
};
harden(normalizeAddress);

export const execSwingsetTransaction = (swingsetArgs, net, from, dryRun) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another powerful export. (closes over execSync and process)

I would appreciate comments that acknowledge this technical debt.

packages/agoric-cli/test/agops-governance-smoketest.sh
# Provision your wallet
make ACCT_ADDR=$KEY AGORIC_POWERS=SMART_WALLET fund-acct provision-acct
agoric wallet provision --account <key-name>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@turadg turadg added automerge:no-update (expert!) Automatically merge without updates bypass:integration Prevent integration tests from running on PR labels Sep 15, 2022
@mergify mergify bot merged commit eb3eb6e into master Sep 15, 2022
@mergify mergify bot deleted the 6211-cli-provision branch September 15, 2022 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dckc dckc dckc approved these changes

Assignees

@dckc dckc

@samsiegart samsiegart

Labels
automerge:no-update (expert!) Automatically merge without updates bypass:integration Prevent integration tests from running on PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@turadg @dckc @samsiegart