-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cosmic-proto exports #6521
Conversation
740ff3b
to
d62fda5
Compare
@@ -38,7 +38,7 @@ | |||
"files": [ | |||
"build", | |||
"LICENSE*", | |||
"swingset/*" | |||
"gen" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will work if we include both swingset
(symlink sources) and gen
(symlink targets).
"./swingset/msgs.js": "./gen/agoric/swingset/msgs.js", | ||
"./swingset/msgs.ts": "./gen/agoric/swingset/msgs.ts", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably okay but we still need the symlinks for systems that don’t support exports
directives, like some bundlers. It would probably be safer in the face of maintenance to leave these alone and rely on the symlinks.
d62fda5
to
36a1f8c
Compare
When I I though this might be sanitization in the registry, but I just noticed
Apparently this is by design: npm/npm#3310 I'll work on a prepack to include them. |
Description
https://www.npmjs.com/package/@agoric/cosmic-proto doesn’t have any code. I thought #6510 would solve that, but a build of agoric-sdk with it still doesn’t have them.
I tried removing the
swingset/*
symlinks but it broke consumers that don't understand package.jsonexports
.Security Considerations
--
Documentation Considerations
--
Testing Considerations
CI. I see this is covered (transitively) by
test-publish-bundle.js
.