build: stop rebuilding for pack #6558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With dist/ checked in, the necessary files are already available. Also, this broke in CI where isn't available.
kriskowal
approved these changes
Nov 10, 2022
turadg
added
automerge:no-update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
npm packCI step for cosmic-proto started failing after #6540.The problem was it added a
prepackthat made a dependency onprotocwhich isn't available in that env. This removes the prepack, which wasn't necessary once thedist/files were added to SCM.Security Considerations
Documentation Considerations
Testing Considerations
Unlinked
protoclocally and verifiednpm packworks.