Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cosmic-proto exports through npm #6583

Merged
merged 2 commits into from
Nov 17, 2022
Merged

fix: cosmic-proto exports through npm #6583

merged 2 commits into from
Nov 17, 2022

Conversation

turadg
Copy link
Member

@turadg turadg commented Nov 17, 2022

Description

#6540 didn't solve for NPM consumers that don't support export maps.

This puts files in swingset instead of symlinks, so they go through npm pack. It re-exports instead of copying because the source code needs to be able to reference ../cosmos and having that in the second path would require copying that directory too.

Security Considerations

Documentation Considerations

Testing Considerations

❯ npm pack
npm notice
npm notice 📦  @agoric/cosmic-proto@0.2.1
npm notice === Tarball Contents ===
npm notice 11.4kB LICENSE
npm notice 352B   README.md
npm notice 18.0kB dist/agoric/swingset/msgs.d.ts
npm notice 17.9kB dist/agoric/swingset/msgs.js
npm notice 14.0kB dist/agoric/swingset/query.d.ts
npm notice 9.6kB  dist/agoric/swingset/query.js
npm notice 16.3kB dist/agoric/swingset/swingset.d.ts
npm notice 17.0kB dist/agoric/swingset/swingset.js
npm notice 3.3kB  dist/cosmos/base/v1beta1/coin.d.ts
npm notice 6.1kB  dist/cosmos/base/v1beta1/coin.js
npm notice 1.8kB  package.json
npm notice 90B    swingset/msgs.js
npm notice 91B    swingset/query.js
npm notice 94B    swingset/swingset.js
npm notice === Tarball Details ===
npm notice name:          @agoric/cosmic-proto
npm notice version:       0.2.1
npm notice filename:      @agoric/cosmic-proto-0.2.1.tgz
npm notice package size:  16.6 kB
npm notice unpacked size: 116.1 kB
npm notice shasum:        a5ccc3df532c938d4bfe06e1b870117e4c436465
npm notice integrity:     sha512-nphByyltyAeaQ[...]tQCs/SLkD0rQg==
npm notice total files:   14

(The swingset files are there)

@turadg turadg requested review from kriskowal and dckc November 17, 2022 20:39
@turadg turadg changed the title Ta/cosmic proto pack fix: cosmic-proto exports through npm Nov 17, 2022
Copy link
Member

@dckc dckc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a smoke test showed this works

@dckc dckc added the bypass:integration Prevent integration tests from running on PR label Nov 17, 2022
@turadg turadg force-pushed the ta/cosmic-proto-pack branch from b20b362 to ae4772b Compare November 17, 2022 22:43
@turadg turadg added the automerge:no-update (expert!) Automatically merge without updates label Nov 17, 2022
@mergify mergify bot merged commit a5437cf into master Nov 17, 2022
@mergify mergify bot deleted the ta/cosmic-proto-pack branch November 17, 2022 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:no-update (expert!) Automatically merge without updates bypass:integration Prevent integration tests from running on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants