Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tool for auditing dangling kindID references #7659

Merged
merged 1 commit into from
Jun 20, 2023
Merged

Tool for auditing dangling kindID references #7659

merged 1 commit into from
Jun 20, 2023

Conversation

FUDCo
Copy link
Contributor

@FUDCo FUDCo commented May 9, 2023

Closes #7655

@FUDCo FUDCo added the enhancement New feature or request label May 9, 2023
@FUDCo FUDCo requested a review from warner May 9, 2023 22:17
@FUDCo FUDCo self-assigned this May 9, 2023
@FUDCo FUDCo changed the title feat: tool for auditing dangling kindID references Tool for auditing dangling kindID references May 9, 2023
@FUDCo
Copy link
Contributor Author

FUDCo commented May 9, 2023 •
edited
Loading

I'm now thinking that the files that are in packages/SwingSet/tools and packages/SwingSet/misc-tools should be somewhere in packages/swing-store (though not entire sure where in there). This would also get rid of the change to SwingSet/package.json.

@FUDCo FUDCo force-pushed the 7655-baggage-check branch from 663db64 to ee7ba0b Compare May 22, 2023 21:08
@FUDCo FUDCo force-pushed the 7655-baggage-check branch 2 times, most recently from f9fcdaa to 9e79d94 Compare June 9, 2023 21:25
warner
warner approved these changes Jun 19, 2023
View reviewed changes
Copy link
Member

@warner warner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good.. I didn't look at it too closely, but the stakes are low if we missed something

packages/SwingSet/package.json
@@ -52,6 +52,7 @@
"@endo/promise-kit": "^0.2.56",
"@endo/ses-ava": "^0.2.40",
"@endo/zip": "^0.2.31",
"better-sqlite3": "^8.2.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we make this a devDependency? I feel like I've managed this in misc-tools/ scripts before (like extract-transcript?).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, maybe the fact that it's in tools/ is why it needs to be a real dependency

@warner
Copy link
Member

warner commented Jun 19, 2023

As discussed, maybe this wants to live in packages/swingset-liveslots/ rather than in the kernel. OTOH it's kernel clients who should be using it, and they don't care that it really talks about data structures managed by liveslots.

@FUDCo FUDCo force-pushed the 7655-baggage-check branch from 9e79d94 to eeadc46 Compare June 20, 2023 22:13
@FUDCo FUDCo enabled auto-merge June 20, 2023 22:13
@FUDCo FUDCo added this pull request to the merge queue Jun 20, 2023
Merged via the queue into master with commit 696f0a8 Jun 20, 2023
@FUDCo FUDCo deleted the 7655-baggage-check branch June 20, 2023 22:59
mhofman pushed a commit that referenced this pull request Aug 7, 2023
@FUDCo @mhofman
Merge pull request #7659 from Agoric/7655-baggage-check
7cc4734 
Tool for auditing dangling kindID references
mhofman pushed a commit that referenced this pull request Aug 7, 2023
@FUDCo @mhofman
Merge pull request #7659 from Agoric/7655-baggage-check
9ced13f 
Tool for auditing dangling kindID references
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@warner warner warner approved these changes

Assignees

@FUDCo FUDCo

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Audit baggage for missing kindID handles
2 participants
@FUDCo @warner