upgrade-test: split targets #7835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphdev
force-pushed
the
raph/ut-target-steps
branch
from
4bcc449 to
2824bd3
Compare
raphdev
force-pushed
the
raph/ut-target-steps
branch
2 times, most recently
from
bedc81b to
244766c
Compare
raphdev
force-pushed
the
raph/ut-target-steps
branch
from
244766c to
b0720f0
Compare
raphdev
force-pushed
the
raph/ut-target-steps
branch
from
eace046 to
8754b09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #7797
Description
This PR splits make targets to align with docker targets, allowing a particular target to tag all the predecessors to avoid a rebuild just to get a particular tag. We also refactor makefile to use this behavior, simplifying steps.
Security Considerations
Scaling Considerations
Documentation Considerations
No changes in documentation.
Testing Considerations
This should slightly benefit cache and make testing better:
For example, this should not cause a rebuild (assuming no files were changed):
make build TARGET=agoric-upgrade-10make build run TARGET=agoric-upgrade-9This will cause a rebuild only to maintain separate cache for test and non-test bootstraps, but thereafter should not cause rebuild:
make build_test TARGET=agoric-upgrade-10make build_test run TARGET=agoric-upgrade-9