btest adding collateral #7892
Merged
btest adding collateral #7892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turadg
force-pushed
the
ta/multiple-collats
branch
2 times, most recently
from
472a639 to
6e9cd61
Compare
turadg
force-pushed
the
ta/multiple-collats
branch
from
6e9cd61 to
3740a15
Compare
Chris-Hibbert
approved these changes
Jun 7, 2023
| @@ -242,6 +256,7 @@ export const getManifestForPriceFeed = async ( | |||
| }, | |||
| }, | |||
| installations: { | |||
| // ??? will every eval of price-feed-proposal will install priceAggregator ? | |||
There was a problem hiding this comment.
syntax: "will" appears twice here. One of them is extraneous.
Comment on lines
358
to
364
| // console.log(collateralBrandKey, 'step 10 of 10'); | ||
| // readLatest('published.auction.schedule'); | ||
| // await advanceTimeBy(3, 'minutes'); | ||
|
|
||
| // console.log(collateralBrandKey, 'step 11 of 10'); | ||
| // readLatest('published.auction.schedule'); | ||
| // await advanceTimeBy(3, 'minutes'); |
turadg
force-pushed
the
ta/multiple-collats
branch
from
3740a15 to
247970e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no tickets
Description
Test with production bootstrap of adding a new collateral and running liquidations with it.
Security Considerations
Scaling Considerations
Documentation Considerations
Testing Considerations
Do we want this in RC3? It adds test coverage but it also lightly changes some proposal code and error handling in vaults.