-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DO NOT MERGE: what if we rebuild yarn.lock experiment #7915
base: master
Are you sure you want to change the base?
Conversation
d3e3dfd
to
a63bba7
Compare
This PR is currently tripping up all the careful CI validation that nothing in |
I don't see any changes. Did I understand your suggested experiment correctly? agoric-sdk(master)$ git checkout markm-fresh-dep-experiment-only
Switched to branch 'markm-fresh-dep-experiment-only'
Your branch is up to date with 'origin/markm-fresh-dep-experiment-only'.
agoric-sdk(markm-fresh-dep-experiment-only)$ yarn install
yarn install v1.22.19
[1/5] 🔍 Validating package.json...
[2/5] 🔍 Resolving packages...
success Already up-to-date.
$ patch-package
patch-package 6.5.1
Applying patches...
@agoric/wallet-ui@0.1.3-solo.0 ✔
acorn@8.8.2 ✔
ava@5.3.0 ✔
bufferfromfile@0.4.377 ✔
depd@2.0.0 ✔
encoding@0.1.13 ✔
express@4.18.2 ✔
external-editor@3.1.0 ✔
node-fetch@2.6.11 ✔
protobufjs@6.11.3 ✔
rxjs@7.8.1 ✔
✨ Done in 2.71s.
agoric-sdk(markm-fresh-dep-experiment-only)$ git status
On branch markm-fresh-dep-experiment-only
Your branch is up to date with 'origin/markm-fresh-dep-experiment-only'.
nothing to commit, working tree clean
agoric-sdk(markm-fresh-dep-experiment-only)$ |
OIC, I think the failures were stale runs before your latest commit because your branch is out-of-date (which prevents CI from running again). Or maybe not. I'm confused. 😕 |
5aad7b0
to
a8e0648
Compare
@michaelfig I rebased on recent master, |
880da9a
to
a17ed7a
Compare
0370642
to
92122be
Compare
92122be
to
74e9e60
Compare
74e9e60
to
9552d7f
Compare
0b7ec35
to
37bae13
Compare
Just seeing what happens if we delete
yarn.lock
and then rebuild it, in order to detect some future compat problems.Also uses the following directive to depend on the endo branch from endojs/endo#1630 , which is the same experiment at the endo level.
#endo-branch: markm-fresh-dep-experiment-only
See also #7937