Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE: what if we rebuild yarn.lock experiment #7915

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

erights
Copy link
Member

@erights erights commented Jun 9, 2023

Just seeing what happens if we delete yarn.lock and then rebuild it, in order to detect some future compat problems.

Also uses the following directive to depend on the endo branch from endojs/endo#1630 , which is the same experiment at the endo level.

#endo-branch: markm-fresh-dep-experiment-only

See also #7937

@michaelfig
Copy link
Member

This PR is currently tripping up all the careful CI validation that nothing in yarn.lock changes during running a yarn install and build. Maybe try running a top-level yarn install locally and see what differences it introduces.

@erights
Copy link
Member Author

erights commented Jun 12, 2023

This PR is currently tripping up all the careful CI validation that nothing in yarn.lock changes during running a yarn install and build. Maybe try running a top-level yarn install locally and see what differences it introduces.

I don't see any changes. Did I understand your suggested experiment correctly?

agoric-sdk(master)$ git checkout markm-fresh-dep-experiment-only
Switched to branch 'markm-fresh-dep-experiment-only'
Your branch is up to date with 'origin/markm-fresh-dep-experiment-only'.

agoric-sdk(markm-fresh-dep-experiment-only)$ yarn install
yarn install v1.22.19
[1/5] 🔍  Validating package.json...
[2/5] 🔍  Resolving packages...
success Already up-to-date.
$ patch-package
patch-package 6.5.1
Applying patches...
@agoric/wallet-ui@0.1.3-solo.0 ✔
acorn@8.8.2 ✔
ava@5.3.0 ✔
bufferfromfile@0.4.377 ✔
depd@2.0.0 ✔
encoding@0.1.13 ✔
express@4.18.2 ✔
external-editor@3.1.0 ✔
node-fetch@2.6.11 ✔
protobufjs@6.11.3 ✔
rxjs@7.8.1 ✔
✨  Done in 2.71s.

agoric-sdk(markm-fresh-dep-experiment-only)$ git status
On branch markm-fresh-dep-experiment-only
Your branch is up to date with 'origin/markm-fresh-dep-experiment-only'.

nothing to commit, working tree clean

agoric-sdk(markm-fresh-dep-experiment-only)$ 

@michaelfig
Copy link
Member

michaelfig commented Jun 12, 2023

I don't see any changes. Did I understand your suggested experiment correctly?

OIC, I think the failures were stale runs before your latest commit because your branch is out-of-date (which prevents CI from running again).

Or maybe not. I'm confused. 😕

@erights erights force-pushed the markm-fresh-dep-experiment-only branch 2 times, most recently from 5aad7b0 to a8e0648 Compare June 14, 2023 18:13
@erights
Copy link
Member Author

erights commented Jun 14, 2023

@michaelfig I rebased on recent master, yarn installed and push --forced. I am now getting different and fewer errors, that are likely also more relevant. Thanks!

@erights erights force-pushed the markm-fresh-dep-experiment-only branch 7 times, most recently from 880da9a to a17ed7a Compare June 15, 2023 05:03
@erights erights force-pushed the markm-fresh-dep-experiment-only branch 4 times, most recently from 0370642 to 92122be Compare June 17, 2023 01:07
@erights erights force-pushed the markm-fresh-dep-experiment-only branch from 92122be to 74e9e60 Compare June 22, 2023 22:28
@erights erights force-pushed the markm-fresh-dep-experiment-only branch from 74e9e60 to 9552d7f Compare June 24, 2023 22:01
@erights erights changed the base branch from master to markm-update-error-message-test June 24, 2023 22:02
@erights erights force-pushed the markm-update-error-message-test branch from 0b7ec35 to 37bae13 Compare June 24, 2023 23:25
Base automatically changed from markm-update-error-message-test to master June 25, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants