fix(cosmos): prevent Golang error wrapping stack frame divergence

[michaelfig]

fixes: #7929

Description

The %w format specifier for wrapping a Golang error object propagates some stack frame information, and thereby affects consensus if sent into SwingSet (since XS heap snapshots and vat transcripts will contain these strings). Use the %s format specifier to stringify Golang error objects so SwingSet is not sensitive to them.

Security Considerations

Improves the ability to release soft-patches that change Golang stack information without affecting consensus data.

Scaling Considerations

n/a

Documentation Considerations

n/a

Testing Considerations

Some simple unit tests were written, but more comprehensive audit or testing would be useful.

[JimLarson]

I see no alternative but eternal vigilance for keeping the errors stack-free.

I also see %w in x/swingset/abci.go. It's in a panic(), but there's no local way to tell if the panic is caught. Please fix that one too.

There's also %w in daemon/cmd/genaccounts.go. This is probably purely client-side - however, there's a benefit for having the whole codebase %w-free. Consider changing those too.

[michaelfig]

I see no alternative but eternal vigilance for keeping the errors stack-free.

Eternal vigilance... hey, I can automate that (or at least some of it)!

there's a benefit for having the whole codebase %w-free.

Will do!