feat(cosmic-proto): stubs for vstorage/query.proto #7950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhofman
approved these changes
Jun 19, 2023
dckc
force-pushed
the
dc-vstorage-js-proto
branch
from
058d50b
to
97b1678
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
mhofman
pushed a commit
that referenced
this pull request
Aug 7, 2023
feat(cosmic-proto): stubs for vstorage/query.proto
This was referenced Feb 20, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #7905
Description
Generate vstorage query stubs to replace ad-hoc implementation in, for example, CLI tools.
Security / Scaling Considerations
n/a
Documentation Considerations
makes the connection to
vstorage/query.protoa bit more clearcc @samsiegart - perhaps we have dapps that borrowed the 3/4ths of a
vstorage/query.protoimplementation that was in our CLI code?Testing Considerations
lightly tested in the context of other work (#7939)
like other code in
@agoric/cosmic-proto, we suppose the generated code doesn't merit its own tests