Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cosmic-proto): stubs for vstorage/query.proto #7950

Merged
merged 3 commits into from
Jun 20, 2023
Merged

Conversation

dckc
Copy link
Member

@dckc dckc commented Jun 19, 2023

refs: #7905

Description

Generate vstorage query stubs to replace ad-hoc implementation in, for example, CLI tools.

Security / Scaling Considerations

n/a

Documentation Considerations

makes the connection to vstorage/query.proto a bit more clear

cc @samsiegart - perhaps we have dapps that borrowed the 3/4ths of a vstorage/query.proto implementation that was in our CLI code?

Testing Considerations

lightly tested in the context of other work (#7939)

like other code in @agoric/cosmic-proto, we suppose the generated code doesn't merit its own tests

@dckc dckc requested review from turadg, kriskowal and mhofman June 19, 2023 22:02
Copy link
Member

@mhofman mhofman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mechanical enough to me.

I have not diffed the generated files locally (we really should have a CI job to verify these generated files are indeed always up to date with their source)

@dckc dckc force-pushed the dc-vstorage-js-proto branch from 058d50b to 97b1678 Compare June 20, 2023 13:31
@dckc dckc enabled auto-merge June 20, 2023 13:32
@dckc dckc added this pull request to the merge queue Jun 20, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 20, 2023
@dckc dckc added this pull request to the merge queue Jun 20, 2023
Merged via the queue into master with commit 657b621 Jun 20, 2023
@dckc dckc deleted the dc-vstorage-js-proto branch June 20, 2023 16:48
mhofman pushed a commit that referenced this pull request Aug 7, 2023
feat(cosmic-proto): stubs for vstorage/query.proto
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants