chore(types): correct ManifestBundleRef #7957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dckc
approved these changes
Jun 20, 2023
| * @typedef BundleHandle | ||
| * @property {string} [bundleName] | ||
| * @typedef {{ bundleName: string } | { bundleID: string} } ManifestBundleRef |
There was a problem hiding this comment.
a thought on product interface boundaries...
One consumer (metamask) pointed out that even though the types have no runtime impact, they can represent breaking changes in the sense that ci jobs fail and effort is needed to address them. This type is exported, so renaming it is a breaking change, from that angle. (I suppose changing its definition could be too)
I don't think that should hold up this PR, but I hope we decide soon on a pretty clear set of product interfaces.
There was a problem hiding this comment.
Good to raise. I queued it for our discussion about breaking changes.
mhofman
pushed a commit
that referenced
this pull request
Aug 7, 2023
chore(types): correct ManifestBundleRef
mhofman
pushed a commit
that referenced
this pull request
Jan 13, 2024
chore(types): correct ManifestBundleRef
mhofman
pushed a commit
that referenced
this pull request
Jan 15, 2024
chore(types): correct ManifestBundleRef
mhofman
pushed a commit
that referenced
this pull request
Jan 19, 2024
chore(types): correct ManifestBundleRef
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Document some type info found while debugging with @Chris-Hibbert
Security Considerations
Scaling Considerations
Documentation Considerations
Testing Considerations