test: a test framework for verifying upgrade of Zoe and ZCF #7966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 22, 2023
Merged
Chris-Hibbert
force-pushed
the
6678-test-upgradeZoeZcf
branch
2 times, most recently
from
700e334 to
4f384fc
Compare
Chris-Hibbert
force-pushed
the
6678-upgradeZoeZcf
branch
from
a7895a9 to
9b24615
Compare
Chris-Hibbert
force-pushed
the
6678-test-upgradeZoeZcf
branch
3 times, most recently
from
ee15adb to
1618fb4
Compare
Chris-Hibbert
force-pushed
the
6678-upgradeZoeZcf
branch
from
9b24615 to
879104f
Compare
This was referenced Jun 23, 2023
Closed
Chris-Hibbert
force-pushed
the
6678-test-upgradeZoeZcf
branch
from
1618fb4 to
37ab31a
Compare
Chris-Hibbert
force-pushed
the
6678-upgradeZoeZcf
branch
from
9c4771e to
3b65d03
Compare
Chris-Hibbert
force-pushed
the
6678-test-upgradeZoeZcf
branch
from
37ab31a to
cde1e35
Compare
Chris-Hibbert
added a commit
that referenced
this pull request
Jul 20, 2023
Build bundles locally, and add instructions for that. Fix prober script to survive when the prober was bundled with the helper version of atomicRearrange from the future, but it's run under an older docker image.
turadg
requested changes
Jul 21, 2023
| /** @typedef {Awaited<ReturnType<typeof makeSwingsetTestKit>>} SwingsetTestKit */ | ||
|
|
||
| export const makeTestContext = async t => { |
There was a problem hiding this comment.
it's only the context for test-vats-restart. why move this from that module to this shared one?
There was a problem hiding this comment.
I thought there would be more sharing. I moved it back.
|
|
||
| // to retain for ESlint, used by typedef | ||
| E; | ||
|
|
||
| // main/production config doesn't have initialPrice, upon which 'open vaults' depends | ||
| const PLATFORM_CONFIG = '@agoric/vats/decentral-itest-vaults-config.json'; |
There was a problem hiding this comment.
I don't think this should be in specified in supports. Each test can choose.
There was a problem hiding this comment.
moved with makeTestContext()
| }; | ||
|
|
||
| export const makeZoeTestContext = async t => { | ||
| console.time('DefaultTestContext'); |
There was a problem hiding this comment.
consider ZoeTestContext. but also, why put in the common supports? It's used only one in test.
There was a problem hiding this comment.
changed, and moved
| const source = `${dirname}/${ZCF_PROBE_SRC}`; | ||
|
|
||
| const zcfProbeBundle = await bundleSource(source); | ||
| // uncomment and add `import fs from "fs";` to generate a bundle of the prober contract |
There was a problem hiding this comment.
please clarify under what conditions someone would need to do this
There was a problem hiding this comment.
It's only needed to build the prober which will be used in the deployment test. Once it has been built once, and checked in with #8018, it won't need to be done again.
But the reviewer of that PR may reasonably demand the ability to reproduce the process, so we describe it here.
turadg
approved these changes
Jul 22, 2023
Chris-Hibbert
force-pushed
the
6678-test-upgradeZoeZcf
branch
from
48340ce to
6bea479
Compare
Chris-Hibbert
added a commit
that referenced
this pull request
Jul 25, 2023
Build bundles locally, and add instructions for that. Fix prober script to survive when the prober was bundled with the helper version of atomicRearrange from the future, but it's run under an older docker image.
It starts from the currently installed version of Zoe and ZCF. First it verifies that reallocation via staging and via the helper work and that the version internal to ZCF is not present. It then upgrades Zoe and ZCF as necessary to introduce the new behavior. Finally, it re-runs the initial verification to show that the ZCF internal version works. This currently fails on the first step since it runs in a state in which the new Zoe/ZCF code has already replaced the old. Variants of this test will run on master without this PR to verify that upgrading to the new Zoe/ZCF works, and in deployment/upgrade-test to show that the upgrade to the new zoe & zcf will succeed.
Chris-Hibbert
force-pushed
the
6678-test-upgradeZoeZcf
branch
from
6bea479 to
5813535
Compare
mhofman
pushed a commit
that referenced
this pull request
Aug 7, 2023
test: a test framework for verifying upgrade of Zoe and ZCF
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #6678
Description
a test framework for verifying upgrade of Zoe and ZCF. This includes bootstrap scripts that can be used to upgrade Zoe and ZCF.
The test starts from the currently installed version of Zoe and ZCF. First it verifies that reallocation via staging and via the helper work and that the version internal to ZCF is not present. It then upgrades Zoe and ZCF as necessary to introduce the new behavior. Finally, it re-runs the initial verification to show that the ZCF internal version works.
This currently fails on the first step since it runs in a state in which the new Zoe/ZCF code has already replaced the old. To check it in, we will change the parity of the test that the new internal
zcf.atomicRearrange()is not present, since this version runs in an environment where that change has already been made.Variants of this test will run on master without this PR to verify that upgrading to the new Zoe/ZCF works, and in
deployment/upgrade-test to show that the upgrade to the new zoe & zcf will succeed. A copy of this code run on master without this PR, with bundles containing the new Zoe & ZCF code will show that the upgrade from the current state succeeds, and zcf's behavior in the probe contract will be different before and after.
Security Considerations
Validates the upgrade plan.
Scaling Considerations
None
Documentation Considerations
None
Testing Considerations
It's all about testing.