fix: reset lockedQuote even when nothing will be auctioned #8070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chris-Hibbert
added
bug
turadg
reviewed
Jul 19, 2023
| @@ -1094,6 +1094,7 @@ export const prepareVaultManagerKit = ( | |||
| state.lockedQuote = undefined; | |||
|
|
|||
| if (vaultData.getSize() === 0) { | |||
| void helper.writeMetrics(); | |||
There was a problem hiding this comment.
on line 1160 it awaits before returning. Which is correct?
also that one superfluously references facets.
There was a problem hiding this comment.
on line 1160 it awaits before returning. Which is correct?
There were more calls that said void than await, so ... No, that's not a good justification.
I don't see any reason that the calling environment wants to respond to the result or wait for it to finish, so I changed them all to void.
also that one superfluously references facets.
fixed
| await aethVaultMetrics.assertChange({ | ||
| lockedQuote: null, |
turadg
approved these changes
Jul 19, 2023
Chris-Hibbert
force-pushed
the
8041-resetLockedQuote
branch
from
9e920c3 to
c5b4e33
Compare
mhofman
pushed a commit
that referenced
this pull request
Aug 7, 2023
fix: reset lockedQuote even when nothing will be auctioned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #8041
Description
When there were no vaults to be liquidated, we exited early, and missed the step of reseting the locked quote. This fixes that oversight.
Security Considerations
None
Scaling Considerations
None
Documentation Considerations
None
Testing Considerations
Appropriate tests were sensitive to the change and had to be updated.