ci(restore-node): avoid clobbering #endo-branch: setup
#8155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelfig
force-pushed
the
mfig-endo-branch-cache
branch
3 times, most recently
from
9cc712d
to
999d7d7
Compare
michaelfig
force-pushed
the
mfig-endo-branch-cache
branch
4 times, most recently
from
741e4f1
to
52a2ab6
Compare
mhofman
approved these changes
Aug 9, 2023
michaelfig
force-pushed
the
mfig-endo-branch-cache
branch
from
52a2ab6
to
84101f1
Compare
mhofman
pushed a commit
that referenced
this pull request
Aug 15, 2023
ci(restore-node): avoid clobbering `#endo-branch:` setup
mhofman
pushed a commit
that referenced
this pull request
Aug 15, 2023
ci(restore-node): avoid clobbering `#endo-branch:` setup
mhofman
pushed a commit
that referenced
this pull request
Jan 12, 2024
ci(restore-node): avoid clobbering `#endo-branch:` setup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#not-endo-branch: markm-options-harmony
closes: #8148
Description
As described in #8148 (comment) , fix two problems with the
.github/actions/restore-nodecomposite CI action that interacted badly with the#endo-branch:PR setting.Background: the
#endo-branch: XXXcomment in a PR description will causerestore-nodeto override package references inyarn.lockwith packages built from theXXXbranch of https://github.com/endojs/endoThe compounding problems:
restore-nodepatchedpackage.jsonand then, after runningyarn install, restored it andyarn.lock. This meant any subsequent installs would overwrite packages installed by the override with the repository default versions.restore-nodealso usedclean: 'false'instead ofclean: false. The string'false'is truthy, so that causedtest-cosmic-swingset's use ofbin/agdto detect changes in installation timestamps and thereby rerunyarn install, provoking the above problem.Security Considerations
n/a
Scaling Considerations
Slightly speeds up
test-cosmic-swingset.Documentation Considerations
n/a
Testing Considerations
Tested by examining the output of
#endo-branch: markm-options-harmony's run oftest-cosmic-swingset.Upgrade Considerations
n/a