refactor(x/swingset): shared KVEntry and helpers #8175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use for swing-store export data Standardize Json handling of export data
mhofman
added a commit
that referenced
this pull request
Aug 15, 2023
…-refactor refactor(x/swingset): shared KVEntry and helpers
mhofman
added a commit
that referenced
this pull request
Aug 15, 2023
…-refactor refactor(x/swingset): shared KVEntry and helpers
mhofman
added a commit
that referenced
this pull request
Aug 16, 2023
…-refactor refactor(x/swingset): shared KVEntry and helpers
mhofman
added a commit
that referenced
this pull request
Aug 16, 2023
…-refactor refactor(x/swingset): shared KVEntry and helpers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #8043 #8031
Description
This is the shared KVEntry and related helpers extracted from #8043.
It's a pure refactor PR which moves the vstorage StorageEntry to a shared KVEntry, adds KVEntryReader which an iterator-like abstraction for KVEntry, and changes the vstorage and swingset modules to use the new abstractions where appropriate.
Security Considerations
None
Scaling Considerations
None
Documentation Considerations
None
Testing Considerations
Added unit tests to cover the KVEntry logic and the new KVEntryReader helpers
Upgrade Considerations
None