fix(publish-kit): workaround endo bug #1728

[erights]

Works around bug endojs/endo#1728 by omitting method guards for symbol-named methods.

Detected by #7937 as a consequence of the stricter checking just merged from endojs/endo#1715 . The InterfaceGuards created by this code were always incorrect in this manner. But previous error checking was too lax to catch it.

CI on this PR checks it against the endo normally used by agoric-sdk. #8233 checks this same change against "current" endo master, to see if this PR fixes the endojs/endo#1728 problem detected by #7937

[michaelfig]

LGTM as a workaround.

[gibson042]

Should we instead fix this in endo, e.g. by updating makeInterfaceGuard?

 export const assertInterfaceGuard = specimen => {
   mustMatch(specimen, InterfaceGuardShape, 'interfaceGuard');
 };
 harden(assertInterfaceGuard);
+
+const { comparator: passableComparator } = makeComparatorKit();
 
 /**
  * @param {string} interfaceName
  * @param {Record<string, MethodGuard>} methodGuards
  * @param {{sloppy?: boolean}} [options]
  * @returns {InterfaceGuard}
  */
 const makeInterfaceGuard = (interfaceName, methodGuards, options = {}) => {
   const { sloppy = false } = options;
+  const stringMethodGuards = {};
+  const symbolMethodGuardsEntries = [];
+  for (const key of ownKeys(methodGuards)) {
+    const value = methodGuards[key];
+    if (typeof key === 'symbol') {
+      symbolMethodGuardsEntries.push([key, value]);
+    } else {
+      stringMethodGuards[key] = value;
+    }
+  }
+  // Ensure a consistent order.
+  symbolMethodGuardsEntries.sort(([k1], [k2]) => passableComparator(k1, k2));
   /** @type {InterfaceGuard} */
   const result = harden({
     klass: 'Interface',
     interfaceName,
-    methodGuards,
+    methodGuards: stringMethodGuards,
+    symbolMethodGuards: symbolMethodGuardsEntries,
     sloppy,
   });
   assertInterfaceGuard(result);
   return result;
 };

I'm not sure about backwards compatibility requirements here, but at the very least I think an endo issue is warranted.

[erights]

I'm not sure about backwards compatibility requirements here, but at the very least I think an endo issue is warranted.

Damn! I should have filed #8231 as an endo issue, not an agoric-sdk issue. GitHub does have a transfer issue feature, but seemingly only within the same org. Manually moved to endojs/endo#1728

[erights]

Should we instead fix this in endo, e.g. by updating makeInterfaceGuard?

Yes. I like your suggestion of how. Since you've already written the code I'd start with, would you like to take this on? I'll review. Thanks!

Closing this PR in favor of that approach.

[erights]

Closed in favor of endojs/endo#1740