ci: fix integration test skip #8283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhofman
force-pushed
the
mhofman/fix-skipped-integration
branch
from
9f8f1cd
to
89fa19b
Compare
mhofman
force-pushed
the
mhofman/fix-skipped-integration
branch
from
89fa19b
to
9dfcd13
Compare
michaelfig
approved these changes
Aug 30, 2023
mhofman
force-pushed
the
mhofman/fix-skipped-integration
branch
from
9dfcd13
to
e4b2f48
Compare
mhofman
added
force:integration
mhofman
added a commit
that referenced
this pull request
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#8267 and #8275 attempted to fix the reporting of integration test results, but apparently #8220 still made it through with a skipped integration test.
This changes the mergify rule to always require a successful run of the integration test or a bypass. To accommodate the case of an integration test having successfully run before (e.g.
force:integrationlabel, thenautomerge:label applied on up to date PR after all checks have already passed), this PR also updates the result reporting of the integration test to carry forward this previous success instead of marking it as skipped.Security Considerations
None
Scaling Considerations
None
Documentation Considerations
None
Testing Considerations
Will manually test the carry forward on this PR
Upgrade Considerations
None