Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround babel override mistake #8391

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

mhofman
Copy link
Member

@mhofman mhofman commented Sep 27, 2023

Refs: #8380

Description

These are all the override tamings I found necessary to workaround babel/babel#15995 which is entrained by @endo/bundle-source.

Security Considerations

All this should be safe since it only affects our trusted orchestration code. For the solo I would prefer an entrypoint in @endo/init that only triggered the override taming without unsafe error taming, but I don't think we open any attack surface regardless.

Scaling Considerations

None

Documentation Considerations

None

Testing Considerations

Manually tested as patches on top of release-mainnet1B / latest NPM packages in a dapp that depends on a babel version with this issue.

Upgrade Considerations

None

@mhofman mhofman force-pushed the mhofman/workaround-babel-override-mistake branch from 791119d to 3b7af4d Compare September 27, 2023 03:17
@erights erights self-requested a review September 28, 2023 00:16
Copy link
Member

@erights erights left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

packages/internal/src/node/createBundles.js Show resolved Hide resolved
@mhofman mhofman force-pushed the mhofman/workaround-babel-override-mistake branch from 30ec622 to 4f83b09 Compare November 7, 2023 21:07
Work around babel dep override mistake
Work around babel dep override mistake
@mhofman mhofman force-pushed the mhofman/workaround-babel-override-mistake branch from 4f83b09 to 877c1a1 Compare November 7, 2023 21:10
@mhofman mhofman added the automerge:rebase Automatically rebase updates, then merge label Nov 7, 2023
@mergify mergify bot merged commit 1831bf3 into master Nov 7, 2023
80 checks passed
@mergify mergify bot deleted the mhofman/workaround-babel-override-mistake branch November 7, 2023 21:57
mhofman pushed a commit that referenced this pull request Nov 7, 2023
…e-mistake

Workaround babel override mistake
@kriskowal
Copy link
Member

Thank you. This adds clarity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:rebase Automatically rebase updates, then merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants