Workaround babel override mistake #8391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhofman
force-pushed
the
mhofman/workaround-babel-override-mistake
branch
from
791119d to
3b7af4d
Compare
erights
reviewed
Sep 27, 2023
michaelfig
reviewed
Sep 30, 2023
mhofman
force-pushed
the
mhofman/workaround-babel-override-mistake
branch
from
30ec622 to
4f83b09
Compare
Work around babel dep override mistake
Work around babel dep override mistake
mhofman
force-pushed
the
mhofman/workaround-babel-override-mistake
branch
from
4f83b09 to
877c1a1
Compare
mhofman
pushed a commit
that referenced
this pull request
Nov 7, 2023
…e-mistake Workaround babel override mistake
|
Thank you. This adds clarity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #8380
Description
These are all the override tamings I found necessary to workaround babel/babel#15995 which is entrained by
@endo/bundle-source.Security Considerations
All this should be safe since it only affects our trusted orchestration code. For the
soloI would prefer an entrypoint in@endo/initthat only triggered the override taming without unsafe error taming, but I don't think we open any attack surface regardless.Scaling Considerations
None
Documentation Considerations
None
Testing Considerations
Manually tested as patches on top of
release-mainnet1B/latestNPM packages in a dapp that depends on a babel version with this issue.Upgrade Considerations
None