fix: solo lookup of wallet UI #8392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelfig
approved these changes
Sep 28, 2023
mhofman
force-pushed
the
mhofman/fix-solo-wallet-ui
branch
from
da21b86
to
1ac063e
Compare
mhofman
pushed a commit
that referenced
this pull request
Sep 30, 2023
fix: solo lookup of wallet UI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #8380
Description
During testing of #8374, we encountered an issue when opening the wallet UI (
agoric open) where the wallet UI exposed byag-solo(port 8000), would failed to load fromdapp-foo/node_modules/node_modules/@agoric/wallet-ui/build/index.html.This changes the solo to use
import.resolveto locate thehtmlBasedirrelative to the@agoric/walletpackage, and removes the now unnecessary../../node_modulesrelative path.Security Considerations
None
Scaling Considerations
None
Documentation Considerations
None
Testing Considerations
Manually tested as patch over the
agoric-upgrade-11NPM packages in a dapp. Other integration tests should cover the rest.Upgrade Considerations
None