fix(swing-store): ensure crank savepoint is wrapped in transaction #8429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The second tests fails if I comment out the #8423 fix, as expected.
|
Nice! I'm going to push a commit with a unit test that fails without your fix, just for clarity. |
warner
approved these changes
Oct 4, 2023
mhofman
pushed a commit
that referenced
this pull request
Nov 8, 2023
…ction fix(swing-store): ensure crank savepoint is wrapped in transaction
mhofman
pushed a commit
that referenced
this pull request
Nov 8, 2023
…ction fix(swing-store): ensure crank savepoint is wrapped in transaction
mhofman
pushed a commit
that referenced
this pull request
Nov 10, 2023
…ction fix(swing-store): ensure crank savepoint is wrapped in transaction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #8423
Description
SQLite likes to autocommit when not in transactions. That includes releasing a savepoint. Simple change to ensure we've started a transaction before creating a savepoint.
Security Considerations
None
Scaling Considerations
None
Documentation Considerations
Comment added to the code. There didn't seem to be any other relevant documentation
Testing Considerations
With the consistent repro of #8423, I've verified that after the change, following the steps no longer cause an AppHash failure. There does not seem to be a good place to add an automated test for this case.
Upgrade Considerations
None