feat(cosmic-swingset): add begin block check and transaction #8432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhofman
changed the title
michaelfig
approved these changes
Oct 11, 2023
Comment on lines
760
to
762
| // Start a block transaction, but without changing state | ||
| // for the upcoming begin block check | ||
| saveBeginHeight(0); |
There was a problem hiding this comment.
Why "without changing state"? Saving a 0 is a state change, isn't it?
There was a problem hiding this comment.
The default is 0 when missing, so writing 0 instead of defaulting does not effectively change the state. I'll calrify.
There was a problem hiding this comment.
I could either re-write it as saveBeginHeight(savedBeginHeight); or update the comment, or both. Which one would be more clear?
iomekam
pushed a commit
that referenced
this pull request
Oct 27, 2023
* feat(cosmic-swingset): add being block check and transaction * fixup! feat(cosmic-swingset): add being block check and transaction --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
mhofman
added a commit
that referenced
this pull request
Nov 8, 2023
* feat(cosmic-swingset): add being block check and transaction * fixup! feat(cosmic-swingset): add being block check and transaction --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
mhofman
added a commit
that referenced
this pull request
Nov 8, 2023
* feat(cosmic-swingset): add being block check and transaction * fixup! feat(cosmic-swingset): add being block check and transaction --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
mhofman
added a commit
that referenced
this pull request
Nov 10, 2023
* feat(cosmic-swingset): add being block check and transaction * fixup! feat(cosmic-swingset): add being block check and transaction --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
mhofman
added a commit
that referenced
this pull request
Jan 13, 2024
* feat(cosmic-swingset): add being block check and transaction * fixup! feat(cosmic-swingset): add being block check and transaction --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
mhofman
added a commit
that referenced
this pull request
Jan 15, 2024
* feat(cosmic-swingset): add being block check and transaction * fixup! feat(cosmic-swingset): add being block check and transaction --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
mhofman
added a commit
that referenced
this pull request
Jan 15, 2024
* feat(cosmic-swingset): add being block check and transaction * fixup! feat(cosmic-swingset): add being block check and transaction --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
mhofman
added a commit
that referenced
this pull request
Jan 15, 2024
* feat(cosmic-swingset): add being block check and transaction * fixup! feat(cosmic-swingset): add being block check and transaction --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
mhofman
added a commit
that referenced
this pull request
Jan 19, 2024
* feat(cosmic-swingset): add being block check and transaction * fixup! feat(cosmic-swingset): add being block check and transaction --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
mhofman
added a commit
that referenced
this pull request
Jan 19, 2024
* feat(cosmic-swingset): add being block check and transaction * fixup! feat(cosmic-swingset): add being block check and transaction --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
anilhelvaci
pushed a commit
to Jorge-Lopes/agoric-sdk
that referenced
this pull request
Mar 4, 2024
…8432) * feat(cosmic-swingset): add being block check and transaction * fixup! feat(cosmic-swingset): add being block check and transaction --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #8424
Description
This adds a consistency check for begin/end block, and does so through the host storage section of swing-store, which results in forcibly starting a block transaction at begin block to solve any future variations of #8423.
Security Considerations
None
Scaling Considerations
None
Documentation Considerations
None
Testing Considerations
As usual, this part of cosmic-swingset relies on integration tests which should exercise the happy paths. The unhappy paths are wholly untested.
Upgrade Considerations
The enact upgrade may publish bundles, so it's also protected with a no-op state change to start a transaction.
The new saved state is fully backwards compatible, and will be created the first time needed (after an upgrade, or after a state-sync restore)