feat: allow clawback vesting accounts to return grants #8616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhofman
reviewed
Dec 5, 2023
| @@ -106,7 +106,7 @@ t: | |||
|
|
|||
| TM_URL := file://$(shell go list -m -f '{{ .Dir }}' github.com/tendermint/tendermint)/proto/tendermint | |||
| GOGO_PROTO_URL := file://$(shell go list -m -f '{{ .Dir }}' github.com/gogo/protobuf) | |||
| IBC_PROTO_URL := file://$(shell go list -m -f '{{ .Dir }}' github.com/cosmos/ibc-go/v3)/proto/ibc/core | |||
| IBC_PROTO_URL := file://$(shell go list -m -f '{{ .Dir }}' github.com/cosmos/ibc-go/v4)/proto/ibc/core | |||
There was a problem hiding this comment.
Probably. I was running bin/agd and probably missed the message from this in all the chatter.
michaelfig
approved these changes
Dec 6, 2023
JimLarson
force-pushed
the
8570-return-grants
branch
from
7966856 to
a88eb8a
Compare
mhofman
pushed a commit
that referenced
this pull request
Dec 6, 2023
feat: allow clawback vesting accounts to return grants
mhofman
pushed a commit
that referenced
this pull request
Dec 6, 2023
feat: allow clawback vesting accounts to return grants
mhofman
pushed a commit
that referenced
this pull request
Dec 6, 2023
feat: allow clawback vesting accounts to return grants
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #8570
Description
Pick up new
agd tx auth vesting return-grantscommand from latest cosmos-sdk.Adapt lien account wrappers for the new method.
Security Considerations
Allows the limited ability to transfer staked and unbonding tokens. This does not subvert the issues addressed by the unbonding delay, as they can only be transferred to the funder of the grant, not an arbitrary 3rd party.
Scaling Considerations
Like clawback, this is a relatively expensive operation.
Documentation Considerations
Command documentation should be adequate.
Testing Considerations
Need to ensure end-to-end functioning of the command in the presence of the lien wrappers.
Upgrade Considerations
N/A: doesn't affect stored data