Add new Vtransfer module for notifications #8624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelfig
reviewed
Dec 6, 2023
schnetzlerjoe
force-pushed
the
vtransfer
branch
from
e06b26c
to
8e15046
Compare
michaelfig
force-pushed
the
vtransfer
branch
3 times, most recently
from
af2951e
to
8faa03a
Compare
michaelfig
force-pushed
the
vtransfer
branch
2 times, most recently
from
b18ae03
to
bb4436e
Compare
michaelfig
force-pushed
the
vtransfer
branch
from
481eb54
to
bb4436e
Compare
michaelfig
force-pushed
the
vtransfer
branch
2 times, most recently
from
45d7718
to
9b9ab3a
Compare
This was referenced Mar 4, 2024
michaelfig
force-pushed
the
vtransfer
branch
2 times, most recently
from
10a5707
to
555df1f
Compare
turadg
requested changes
Mar 11, 2024
michaelfig
force-pushed
the
vtransfer
branch
2 times, most recently
from
bcd287a
to
7f3be7d
Compare
…try rather than in middleware This prevents the authority leak described at Agoric#8624 (comment) .
michaelfig
added
automerge:no-update
michaelfig
pushed a commit
that referenced
this pull request
Jun 10, 2024
michaelfig
pushed a commit
that referenced
this pull request
Jun 10, 2024
#8624 (comment) makeBridgeTargetKit can be more general than "IBC transfer", and is already pulled in separately by vat-transfer.js
mergify bot
added a commit
that referenced
this pull request
Jun 10, 2024
…9471) #8624 (comment) makeBridgeTargetKit can be more general than "IBC transfer", and is already pulled in separately by vat-transfer.js
mhofman
reviewed
Jun 17, 2024
Comment on lines
-154
to
+159
| panic(fmt.Errorf("SwingStore export dir not set")) | ||
| am.swingStoreExportDir = "/tmp/swingset_export" |
There was a problem hiding this comment.
What is the motivation for this change? This is used by genesis import/export which should set this appropriately.
There was a problem hiding this comment.
I don't know the motivation, but I see that @schnetzlerjoe made the change. Perhaps this panic was being triggered by the x/vtransfer ibc_middleware_test.go?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #8583, closes: #9059, closes: #9256
Description
This PR adds the vTransfer middleware module which acts as a notification module on the transfer port for contracts that need to act based on it.
Security Considerations
As discussed, this does change how inbound assets are handled.
Testing Considerations
The middleware module has mock unit tests in ibc_middleware_test.go