Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Avoid out-of-bounds reads in go-lang code #8674

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

gibson042
Copy link
Member

Description

Replace panics with friendly error messages.

Security Considerations

I think all the panics were harmless, but if not then this should make things more robust against malicious input.

Scaling Considerations

n/a

Documentation Considerations

n/a

Testing Considerations

n/a

Upgrade Considerations

n/a

Copy link
Member

@michaelfig michaelfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Always great to see how a proper Gofer would write things. :)

Replace panics with friendly error messages.
@gibson042 gibson042 force-pushed the gibson-2023-12-golang-array-access branch from 159728b to 7f3b821 Compare December 19, 2023 16:20
@gibson042 gibson042 added the automerge:squash Automatically squash merge label Dec 19, 2023
@mergify mergify bot merged commit 9380cfe into master Dec 19, 2023
76 checks passed
@mergify mergify bot deleted the gibson-2023-12-golang-array-access branch December 19, 2023 17:28
anilhelvaci pushed a commit to Jorge-Lopes/agoric-sdk that referenced this pull request Feb 16, 2024
Replace panics with friendly error messages.
mhofman pushed a commit that referenced this pull request Feb 18, 2024
Replace panics with friendly error messages.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:squash Automatically squash merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants