fix(vats): include index.js in NPM package #8815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dckc
approved these changes
Jan 25, 2024
Comment on lines
+58
to
+59
| "index.*", | ||
| "exported.*" |
There was a problem hiding this comment.
is that normally necessary? surely index.js is included in packages by default
There was a problem hiding this comment.
The files pointed to by main and bin are supposed to be automatically includer, but apparently there are not. Maybe another yarn gremlin?
mhofman
added a commit
that referenced
this pull request
Jan 30, 2024
mhofman
added a commit
that referenced
this pull request
Jan 30, 2024
mhofman
added a commit
that referenced
this pull request
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #8809
Description
Add missing file to NPM package
Security Considerations
None
Scaling Considerations
None
Documentation Considerations
None
Testing Considerations
Our test coverage is abysmal here, but out of scope.
I have manually verified that the package now contains all expected files
Upgrade Considerations
Must be included in release branch to be published. Verified that the same change is needed there