fix(agoric-cli): Remove conflicting AggregateError declaration comment #8898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erights
force-pushed
the
markm-remove-conflicting-AggregateError-decl
branch
from
57667a3
to
b4b7c09
Compare
7 tasks
michaelfig
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #XXXX
refs: endojs/endo#2042 (comment) #7937
Description
AggregateErrorhas been part of standard JS for a long time. But endo's permits list does not yet list it, causing it to be omitted from SES. endojs/endo#2042 will supportAggregateErrortogether with the long delayedPromise.any,error.cause, anderror.errors.Trying both #7937 with the endojs/endo#2042 fork, we find one integration failure from line
/* global process AggregateError Buffer */Deleting the
AggregateErrorfrom this comment works with the endojs/endo#2042 fork according to #7937 CI, and works with the endo that agoric-sdk currently depends on, according to this PR's CI. Thus, we can delete the declaration now without breaking anything, and avoid breaking once agoric-sdk is synced with an endo incorporating endojs/endo#2042Security Considerations
none
Scaling Considerations
none
Documentation Considerations
none
Testing Considerations
We originally did the #7937 in order to see if #2042 is compat with XS. It did not detect any such problems, but did detect this instead.
I'd say this corroborates the case that endo CI should at least run agoric-sdk CI lint jobs. Not all integration problems would have been caught be this, of course. But a surprising number would have.
Upgrade Considerations
none