feat(a3p-integration): add core eval in test #8929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhofman
added
force:integration
turadg
approved these changes
Feb 15, 2024
Comment on lines
+12
to
+19
| const replaceTemplateValuesInFile = async (fileName, replacements) => { | ||
| let script = await readFile(`${fileName}.tjs`, 'utf-8'); | ||
| for (const [template, value] of Object.entries(replacements)) { | ||
| script = script.replaceAll(`{{${template}}}`, value); | ||
| } | ||
| await writeFile(`${fileName}.js`, script); | ||
| }; |
There was a problem hiding this comment.
this will be handy for Agoric/agoric-3-proposals#82
mhofman
added
force:integration
mhofman
force-pushed
the
mhofman/8887-core-eval-test
branch
from
3be300d
to
0cd9160
Compare
mhofman
added
automerge:squash
mhofman
added a commit
that referenced
this pull request
Feb 18, 2024
* feat(a3p-integration): add core eval in test * fixup! feat(a3p-integration): add core eval in test * Nudge * test: reduce race sensitivity --------- Co-authored-by: Turadg Aleahmad <turadg@agoric.com>
mhofman
added a commit
that referenced
this pull request
Feb 18, 2024
* feat(a3p-integration): add core eval in test * fixup! feat(a3p-integration): add core eval in test * Nudge * test: reduce race sensitivity --------- Co-authored-by: Turadg Aleahmad <turadg@agoric.com>
mhofman
added a commit
that referenced
this pull request
Feb 18, 2024
* feat(a3p-integration): add core eval in test * fixup! feat(a3p-integration): add core eval in test * Nudge * test: reduce race sensitivity --------- Co-authored-by: Turadg Aleahmad <turadg@agoric.com>
mhofman
added a commit
that referenced
this pull request
Feb 19, 2024
* feat(a3p-integration): add core eval in test * fixup! feat(a3p-integration): add core eval in test * Nudge * test: reduce race sensitivity --------- Co-authored-by: Turadg Aleahmad <turadg@agoric.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #8887
Description
Follow up to #8902 adding a standalone a3p test which verifies core eval governance functionality on an upgraded chain.
Security Considerations
None
Scaling Considerations
None
Documentation Considerations
Serves as a self-documenting template for other similar a3p tests
Testing Considerations
This is adding an a3p test
Upgrade Considerations
This is an integration test of chain software upgrades