fix(SwingSet): silence vat console output during replay #8943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you mean #8572? |
|
Adding |
mhofman
approved these changes
Feb 18, 2024
mhofman
approved these changes
Feb 18, 2024
There was a problem hiding this comment.
I can confirm that the new logs don't include any output from replaying vats during kernel start:
Sun, 18 Feb 2024 05:14:18 GMT
#21 3.455 2024-02-18T05:14:18.469Z launch-chain: Launching SwingSet kernel
Sun, 18 Feb 2024 05:14:51 GMT
#21 36.36 2024-02-18T05:14:51.377Z block-manager: block 967 begin
Sun, 18 Feb 2024 05:14:51 GMT
#21 36.42 2024-02-18T05:14:51.435Z SwingSet: vat: v1: evaluateBundleCap { manifestBundleRef: { bundleID: 'b1-773d4b972ad4fe803de4947c7f907a85a52fc08e1f6789ba1b853db4e691d10c43847612de281b4567710c92a678cf5ee9fa441d71f81a1f2bc538d6f255c75b' }, manifestGetterName: 'getManifestForUpgradeWallet', vatAdminSvc: Promise [Promise] {} }
I am however wondering if we should add a log entry after cosmic-swingset has finished launching the kernel as right now if things get stuck, it'd be hard to determine if we got stuck in kernel or cosmos land.
michaelfig
added
the
automerge:no-update
mhofman
pushed a commit
that referenced
this pull request
Feb 18, 2024
fix(SwingSet): silence vat console output during replay
mhofman
pushed a commit
that referenced
this pull request
Feb 19, 2024
fix(SwingSet): silence vat console output during replay
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #8572
Description
Fix a longstanding issue that confuses anybody who restarts a SwingSet kernel. This is not the most elegant, bandwidth-conserving solution as proposed in #8572, but it scratches the annoying itch of stale console output.
Security Considerations
Scaling Considerations
Documentation Considerations
Testing Considerations
Upgrade Considerations