smart wallet report rejections of durable promises (backport #8998) #9000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
now returns Promise<void> instead of all the records, but they weren't ever used so it won't change behavior
turadg
force-pushed
the
u14/8997-error-handling
branch
from
909c249
to
345ce4b
Compare
erights
reviewed
Feb 27, 2024
turadg
force-pushed
the
u14/8997-error-handling
branch
from
345ce4b
to
17cd7f0
Compare
mhofman
approved these changes
Feb 27, 2024
mhofman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits from #8998 , rebased for dev-upgrade-14
@mhofman merge at will