Start a new auction in a3p-integration #9158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chris-Hibbert
added
performance
turadg
reviewed
Mar 28, 2024
Chris-Hibbert
force-pushed
the
8740-newAuction
branch
from
44189f6
to
49f7ded
Compare
Chris-Hibbert
force-pushed
the
8740-newAuction
branch
from
49f7ded
to
ff78434
Compare
Deploying agoric-sdk with
|
| Latest commit: |
2d5a66a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f55d337f.agoric-sdk.pages.dev |
| Branch Preview URL: | https://8740-newauction.agoric-sdk.pages.dev |
turadg
approved these changes
Apr 25, 2024
a3p-integration/proposals/a:upgrade-next/priceFeed-follower-auction.test.js
Outdated
Show resolved
Hide resolved
Chris-Hibbert
added
the
automerge:rebase
Chris-Hibbert
force-pushed
the
8740-newAuction
branch
from
a0da3d9
to
09080d7
Compare
|
@Chris-Hibbert - This PR appears to be stuck. It's had a merge label for > 24 hours |
1 similar comment
|
@Chris-Hibbert - This PR appears to be stuck. It's had a merge label for > 24 hours |
Chris-Hibbert
force-pushed
the
8740-newAuction
branch
from
3774694
to
2d5a66a
Compare
Merged
anilhelvaci
reviewed
Jul 22, 2024
| }, | ||
| installation: { | ||
| consume: { | ||
| auctioneer: auctionInstallation, |
There was a problem hiding this comment.
Just to make things easier to understand for me, the reason why add-auction uses the existing auctionInstallation is to have a new auction vat that uses new instance(s) of priceFeed since deployed auctioneer isn't upgradable and does NOT have anything to do with replacing auctioneer with its upgradable version. Am I correct? @Chris-Hibbert
There was a problem hiding this comment.
yes, that's correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #8740
closes: #8918
refs: #8400
Description
Add a new Auction instance in A3P, so #8757 can make use of it. Also provides upgrade proposals which can be be applied to MainNet and other chains.
Security Considerations
N/A
Scaling Considerations
This is largely in service of #8400, which reports that priceFeed vats are accumulating garbage. This PR gives a new auction which can rely on new priceFeeds. The existing auction is not upgradeable and its pricefeeds can't be updated.
Documentation Considerations
No user-visible changes to behavior.
Testing Considerations
Tested in A3P
Upgrade Considerations
Auctions are not upgradeable, so we have to replace them and update their clients.