normalize types-ambient #9309
Merged
normalize types-ambient #9309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
a866f98
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f1871c54.agoric-sdk.pages.dev |
| Branch Preview URL: | https://ta-zoe-types.agoric-sdk.pages.dev |
turadg
force-pushed
the
ta/zoe-types
branch
2 times, most recently
from
2e3ae53
to
93c5381
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #9305
Description
While working on #9305 I was slowed down by the
types.jsfiles that were really ambients.This makes all
types.jsthat aren't modules intotypes-ambient.js.The ambients for
zoe/toolsI ditched by making them explicit exports, to continue supporting that part of the package API that theprepackrename was doing.Security Considerations
Scaling Considerations
Documentation Considerations
Testing Considerations
Upgrade Considerations