Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: drop dapp-card-store test #9318

Merged
merged 1 commit into from
May 3, 2024
Merged

ci: drop dapp-card-store test #9318

merged 1 commit into from
May 3, 2024

Conversation

turadg
Copy link
Member

@turadg turadg commented May 3, 2024

no ticket

Description

dapp-card-store is failing a test . The test isn't required but since we no longer support that app this removes it from CI entirely.

Security Considerations

Scaling Considerations

Documentation Considerations

Testing Considerations

Upgrade Considerations

It's to be archived
@turadg turadg requested review from ivanlei and LuqiPan May 3, 2024 16:25
Copy link

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: 683ec9b
Status: ✅  Deploy successful!
Preview URL: https://cba6fbff.agoric-sdk.pages.dev
Branch Preview URL: https://ta-drop-card-store.agoric-sdk.pages.dev

View logs

Copy link
Contributor

@LuqiPan LuqiPan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ivanlei ivanlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@turadg turadg added the automerge:rebase Automatically rebase updates, then merge label May 3, 2024
@mergify mergify bot merged commit 750f249 into master May 3, 2024
74 checks passed
@mergify mergify bot deleted the ta/drop-card-store branch May 3, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:rebase Automatically rebase updates, then merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants