refactor(vats): for state upgrade, use single field #9353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
4433526
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c6e3cec5.agoric-sdk.pages.dev |
| Branch Preview URL: | https://dc-powers-refactor.agoric-sdk.pages.dev |
dckc
changed the title
turadg
approved these changes
May 9, 2024
packages/vats/src/localchain.js
Outdated
| export const LocalChainAdminI = M.interface('LocalChainAdmin', { | ||
| setPower: M.callWhen(M.string(), M.await(M.any())).returns(), | ||
| }); | ||
| // XXX vestigial? for future use? |
There was a problem hiding this comment.
Looks like the motivation for a "kit" is gone. Is there good reason to expect it to return? If not, please simplify to a regular Exo.
There was a problem hiding this comment.
I started to, but then thought: if we change to a regular Exo, it seems like changing our minds back to a Kit would be expensive.
I don't suppose I have any specific reason to expect it to return, though. So... ok, I guess I'll change it to an Exo.
turadg
approved these changes
May 9, 2024
... rather than power store. Also require all localChain powers at intialization, which eliminates the need for the admin.setPower method. admin facet remains, since an exoClassKit has to have >1 facet, keeping the possibility of non-public facets open is not bad.
punt on vestigial admin facet
mergify bot
added a commit
that referenced
this pull request
May 10, 2024
refs: #9342, #9193 stacked on - #9353 ## Description Provide localchain accounts only with the `bank` for the relevant address, rather than giving them access to all accounts in the form of the `bankManager`. earlier discussion: https://github.com/Agoric/agoric-sdk/pull/9342/files#r1594791187 ### Security Considerations bankManager was excess authority ### Scaling / Documentation / Testing Considerations Nothing significant: no scaling changes; existing docs/tests suffice. ### Upgrade Considerations code is not released / deployed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up to: #9086
Description
In preparation for addressing excess authority (#9354):
Security / Documentation Considerations
n/a
Scaling Considerations
small constant factor change: removing the indirection thru the power store removes 1 syscall per access
Testing Considerations
existing tests suffice
Upgrade Considerations
code is not yet released / deployed