Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vow): make watch/when more robust against loops and hangs #9487

Merged
merged 8 commits into from
Jun 12, 2024

fix(vow): allow resolving vow to external promise

44a6d16
Select commit
Loading
Failed to load commit list.
Merged

fix(vow): make watch/when more robust against loops and hangs #9487

fix(vow): allow resolving vow to external promise
44a6d16
Select commit
Loading
Failed to load commit list.
Mergify / Queue: Embarked in merge queue succeeded Jun 12, 2024 in 0s

The pull request embarked with master (26b0505) will be merged soon

Required conditions for merge:

  • #approved-reviews-by>=1 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by=0 [🛡 GitHub branch protection]
  • base=master
  • all of [📃 From pull request rule merge to master]:
    • -draft [📌 queue requirement]
    • base=master
    • label=automerge:no-update
    • any of:
      • #commits-behind=0
      • label=bypass:linear-history
    • any of:
      • check-success=integration-test-result
      • check-pending=integration-test-result
      • label=bypass:integration
    • any of:
      • all of:
        • -label=proto:expect-breakage
        • check-success=breakage
      • all of:
        • check-failure=breakage
        • label=proto:expect-breakage
    • any of [📌 queue -> configuration change requirements]:
      • -mergify-configuration-changed
      • check-success=Configuration changed
    • any of [🔀 queue conditions]:
      • all of [📌 queue conditions of queue main]:
        • #approved-reviews-by>=1 [🛡 GitHub branch protection]
        • #changes-requested-reviews-by=0 [🛡 GitHub branch protection]
        • any of [🛡 GitHub branch protection]:
          • check-success=gotest
          • check-neutral=gotest
          • check-skipped=gotest
        • any of [🛡 GitHub branch protection]:
          • check-success=lint
          • check-neutral=lint
          • check-skipped=lint
        • any of [🛡 GitHub branch protection]:
          • check-success=test-quick (xs)
          • check-neutral=test-quick (xs)
          • check-skipped=test-quick (xs)
        • any of [🛡 GitHub branch protection]:
          • check-success=test-quick2 (xs)
          • check-neutral=test-quick2 (xs)
          • check-skipped=test-quick2 (xs)
        • any of [🛡 GitHub branch protection]:
          • check-success=test-cosmic-swingset (xs)
          • check-neutral=test-cosmic-swingset (xs)
          • check-skipped=test-cosmic-swingset (xs)
        • any of [🛡 GitHub branch protection]:
          • check-success=test-swingset (xs)
          • check-neutral=test-swingset (xs)
          • check-skipped=test-swingset (xs)
        • any of [🛡 GitHub branch protection]:
          • check-success=test-swingset2 (xs)
          • check-neutral=test-swingset2 (xs)
          • check-skipped=test-swingset2 (xs)
        • any of [🛡 GitHub branch protection]:
          • check-success=test-swingset3 (xs)
          • check-neutral=test-swingset3 (xs)
          • check-skipped=test-swingset3 (xs)
        • any of [🛡 GitHub branch protection]:
          • check-success=test-swingset4 (xs)
          • check-neutral=test-swingset4 (xs)
          • check-skipped=test-swingset4 (xs)
        • any of [🛡 GitHub branch protection]:
          • check-success=test-zoe-swingset (xs)
          • check-neutral=test-zoe-swingset (xs)
          • check-skipped=test-zoe-swingset (xs)
        • any of [🛡 GitHub branch protection]:
          • check-success=test-zoe-unit (xs)
          • check-neutral=test-zoe-unit (xs)
          • check-skipped=test-zoe-unit (xs)
        • any of [🛡 GitHub branch protection]:
          • check-success=lint-primary
          • check-neutral=lint-primary
          • check-skipped=lint-primary
        • any of [🛡 GitHub branch protection]:
          • check-success=lint-rest
          • check-neutral=lint-rest
          • check-skipped=lint-rest
        • any of [🛡 GitHub branch protection]:
          • check-success=build (18.x)
          • check-neutral=build (18.x)
          • check-skipped=build (18.x)
        • any of [🛡 GitHub branch protection]:
          • check-success=test-cosmic-swingset (18.x)
          • check-neutral=test-cosmic-swingset (18.x)
          • check-skipped=test-cosmic-swingset (18.x)
        • any of [🛡 GitHub branch protection]:
          • check-success=test-quick (18.x)
          • check-neutral=test-quick (18.x)
          • check-skipped=test-quick (18.x)
        • any of [🛡 GitHub branch protection]:
          • check-success=test-swingset (18.x)
          • check-neutral=test-swingset (18.x)
          • check-skipped=test-swingset (18.x)
        • any of [🛡 GitHub branch protection]:
          • check-success=test-quick2 (18.x)
          • check-neutral=test-quick2 (18.x)
          • check-skipped=test-quick2 (18.x)
        • any of [🛡 GitHub branch protection]:
          • check-success=test-solo (18.x)
          • check-neutral=test-solo (18.x)
          • check-skipped=test-solo (18.x)
        • any of [🛡 GitHub branch protection]:
          • check-success=test-zoe-unit (18.x)
          • check-neutral=test-zoe-unit (18.x)
          • check-skipped=test-zoe-unit (18.x)
        • any of [🛡 GitHub branch protection]:
          • check-success=test-zoe-swingset (18.x)
          • check-neutral=test-zoe-swingset (18.x)
          • check-skipped=test-zoe-swingset (18.x)
        • any of [🛡 GitHub branch protection]:
          • check-success=test-swingset2 (18.x)
          • check-neutral=test-swingset2 (18.x)
          • check-skipped=test-swingset2 (18.x)
        • any of [🛡 GitHub branch protection]:
          • check-success=test-swingset3 (18.x)
          • check-neutral=test-swingset3 (18.x)
          • check-skipped=test-swingset3 (18.x)
        • any of [🛡 GitHub branch protection]:
          • check-success=test-swingset4 (18.x)
          • check-neutral=test-swingset4 (18.x)
          • check-skipped=test-swingset4 (18.x)
        • any of [🛡 GitHub branch protection]:
          • check-success=test-inter-protocol (18.x)
          • check-neutral=test-inter-protocol (18.x)
          • check-skipped=test-inter-protocol (18.x)
        • any of [🛡 GitHub branch protection]:
          • check-success=linear-history
          • check-neutral=linear-history
          • check-skipped=linear-history
        • any of [🛡 GitHub branch protection]:
          • check-success=merge-strategy (chosen)
          • check-neutral=merge-strategy (chosen)
          • check-skipped=merge-strategy (chosen)
        • any of [🛡 GitHub branch protection]:
          • check-success=test-boot (18.x)
          • check-neutral=test-boot (18.x)
          • check-skipped=test-boot (18.x)
        • any of [🛡 GitHub branch protection]:
          • check-success=test-boot (xs)
          • check-neutral=test-boot (xs)
          • check-skipped=test-boot (xs)
  • any of:
    • check-success=integration-test-result
    • label=bypass:integration
  • any of [🛡 GitHub branch protection]:
    • check-success=gotest
    • check-neutral=gotest
    • check-skipped=gotest
  • any of [🛡 GitHub branch protection]:
    • check-success=lint
    • check-neutral=lint
    • check-skipped=lint
  • any of [🛡 GitHub branch protection]:
    • check-success=test-quick (xs)
    • check-neutral=test-quick (xs)
    • check-skipped=test-quick (xs)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-quick2 (xs)
    • check-neutral=test-quick2 (xs)
    • check-skipped=test-quick2 (xs)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-cosmic-swingset (xs)
    • check-neutral=test-cosmic-swingset (xs)
    • check-skipped=test-cosmic-swingset (xs)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-swingset (xs)
    • check-neutral=test-swingset (xs)
    • check-skipped=test-swingset (xs)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-swingset2 (xs)
    • check-neutral=test-swingset2 (xs)
    • check-skipped=test-swingset2 (xs)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-swingset3 (xs)
    • check-neutral=test-swingset3 (xs)
    • check-skipped=test-swingset3 (xs)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-swingset4 (xs)
    • check-neutral=test-swingset4 (xs)
    • check-skipped=test-swingset4 (xs)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-zoe-swingset (xs)
    • check-neutral=test-zoe-swingset (xs)
    • check-skipped=test-zoe-swingset (xs)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-zoe-unit (xs)
    • check-neutral=test-zoe-unit (xs)
    • check-skipped=test-zoe-unit (xs)
  • any of [🛡 GitHub branch protection]:
    • check-success=lint-primary
    • check-neutral=lint-primary
    • check-skipped=lint-primary
  • any of [🛡 GitHub branch protection]:
    • check-success=lint-rest
    • check-neutral=lint-rest
    • check-skipped=lint-rest
  • any of [🛡 GitHub branch protection]:
    • check-success=build (18.x)
    • check-neutral=build (18.x)
    • check-skipped=build (18.x)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-cosmic-swingset (18.x)
    • check-neutral=test-cosmic-swingset (18.x)
    • check-skipped=test-cosmic-swingset (18.x)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-quick (18.x)
    • check-neutral=test-quick (18.x)
    • check-skipped=test-quick (18.x)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-swingset (18.x)
    • check-neutral=test-swingset (18.x)
    • check-skipped=test-swingset (18.x)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-quick2 (18.x)
    • check-neutral=test-quick2 (18.x)
    • check-skipped=test-quick2 (18.x)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-solo (18.x)
    • check-neutral=test-solo (18.x)
    • check-skipped=test-solo (18.x)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-zoe-unit (18.x)
    • check-neutral=test-zoe-unit (18.x)
    • check-skipped=test-zoe-unit (18.x)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-zoe-swingset (18.x)
    • check-neutral=test-zoe-swingset (18.x)
    • check-skipped=test-zoe-swingset (18.x)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-swingset2 (18.x)
    • check-neutral=test-swingset2 (18.x)
    • check-skipped=test-swingset2 (18.x)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-swingset3 (18.x)
    • check-neutral=test-swingset3 (18.x)
    • check-skipped=test-swingset3 (18.x)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-swingset4 (18.x)
    • check-neutral=test-swingset4 (18.x)
    • check-skipped=test-swingset4 (18.x)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-inter-protocol (18.x)
    • check-neutral=test-inter-protocol (18.x)
    • check-skipped=test-inter-protocol (18.x)
  • any of [🛡 GitHub branch protection]:
    • check-success=linear-history
    • check-neutral=linear-history
    • check-skipped=linear-history
  • any of [🛡 GitHub branch protection]:
    • check-success=merge-strategy (chosen)
    • check-neutral=merge-strategy (chosen)
    • check-skipped=merge-strategy (chosen)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-boot (18.x)
    • check-neutral=test-boot (18.x)
    • check-skipped=test-boot (18.x)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-boot (xs)
    • check-neutral=test-boot (xs)
    • check-skipped=test-boot (xs)

Check-runs and statuses of the embarked pull request #9487:

getting-started details
merge-strategy details
Cloudflare Pages — Deployed successfullydetails
breakage details
build (18.x) details
build (20.x) details
codecov/patch — 96.82% of diff hit (target 55.26%)details
codecov/project — 55.25% (-0.01%) compared to 26b0505, passed because coverage increased by -0.01% when compared to adjusted base (55.26%)details
dependency-graph details
deployment-test details
finalize-integration-result details
getting-started (link-cli/yarn) details
getting-started (registry/npm) details
getting-started (registry/npx) details
getting-started (registry/yarn) details
golangci-lint (no-failure) details
gotest details
integration-test-result — Integration Test Aggregate Resultdetails
linear-history details
lint details
lint-primary details
lint-rest details
merge-strategy (chosen) details
pre_check / Check preconditions and cancel previous jobs details
run-scripts-tests details
test-boot (18.x) details
test-boot (20.x) details
test-boot (xs) details
test-cosmic-swingset (18.x) details
test-cosmic-swingset (20.x) details
test-cosmic-swingset (xs) details
test-dapp (18.x) details
test-docker-build details
test-inter-protocol (18.x) details
test-inter-protocol (20.x) details
test-quick (18.x) details
test-quick (20.x) details
test-quick (xs) details
test-quick2 (18.x) details
test-quick2 (20.x) details
test-quick2 (xs) details
test-solo (18.x) details
test-solo (20.x) details
test-swingset (18.x) details
test-swingset (20.x) details
test-swingset (xs) details
test-swingset2 (18.x) details
test-swingset2 (20.x) details
test-swingset2 (xs) details
test-swingset3 (18.x) details
test-swingset3 (20.x) details
test-swingset3 (xs) details
test-swingset4 (18.x) details
test-swingset4 (20.x) details
test-swingset4 (xs) details
test-zoe-swingset (18.x) details
test-zoe-swingset (20.x) details
test-zoe-swingset (xs) details
test-zoe-unit (18.x) details
test-zoe-unit (20.x) details
test-zoe-unit (xs) details
wait-integration-pre-checks details