Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

9281 provideOrchestration to provide asyncTools #9518

Merged
merged 3 commits into from
Jun 18, 2024
Merged

Conversation

turadg
Copy link
Member

@turadg turadg commented Jun 17, 2024

refs: #9281

Description

Orchestration API needs asyncTools. This makes it required for construction. That made the boilerplate in start quite large so this also adds a helper to do all the setup that any orchestration contract needs.

Security Considerations

none

Scaling Considerations

none

Documentation Considerations

Part of these example contracts

Testing Considerations

Existing coverage suffics

Upgrade Considerations

Not yet deployed

@turadg turadg requested review from dtribble and 0xpatrickdev June 17, 2024 21:28
Copy link

cloudflare-workers-and-pages bot commented Jun 17, 2024

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: f096604
Status: ✅  Deploy successful!
Preview URL: https://072be0e8.agoric-sdk.pages.dev
Branch Preview URL: https://9281-provideasynctools.agoric-sdk.pages.dev

View logs

@turadg turadg force-pushed the 9281-provideAsyncTools branch from 05cd7ee to f096604 Compare June 18, 2024 01:11
@erights erights self-requested a review June 18, 2024 15:50
Copy link
Member

@0xpatrickdev 0xpatrickdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The @agoric/orchestration changes LGTM.

Noticing some missing semicolons in the async-flow type imports, like Zone and PromiseKit

@turadg turadg added the automerge:rebase Automatically rebase updates, then merge label Jun 18, 2024
@mergify mergify bot merged commit a035bbe into master Jun 18, 2024
85 checks passed
@mergify mergify bot deleted the 9281-provideAsyncTools branch June 18, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:rebase Automatically rebase updates, then merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants